From: Jan Krüger Date: Sun, 30 May 2010 08:19:26 +0000 (+0200) Subject: git-am: suggest what to do with superfluous patches X-Git-Tag: v1.7.2-rc0~50^2 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=05bdcfe5fc3d626b752c2cb574f05ed30b279bcf;p=git.git git-am: suggest what to do with superfluous patches Particularly in the context of rebase, conflicts frequently occur because the change in the patch to be applied was made obsolete by new upstream commits. In this case, solving the conflict effectively means skipping the patch. However, it's not always readily apparent that the patch needs to be skipped, and when people solve the conflict and try git rebase --continue, they get confronted with a message of No changes - did you forget to use 'git add'? That's not very helpful if you did actually stage your changes and they happen to turn the patch into a no-op. This extends the message to point out what's going on. Signed-off-by: Jan Krüger Signed-off-by: Junio C Hamano --- diff --git a/git-am.sh b/git-am.sh index 87ffae252..43ea52c15 100755 --- a/git-am.sh +++ b/git-am.sh @@ -726,6 +726,8 @@ do resolved= git diff-index --quiet --cached HEAD -- && { echo "No changes - did you forget to use 'git add'?" + echo "If there is nothing left to stage, chances are that something else" + echo "already introduced the same changes; you might want to skip this patch." stop_here_user_resolve $this } unmerged=$(git ls-files -u)