From: Jakub Narebski Date: Sat, 18 Nov 2006 22:35:38 +0000 (+0100) Subject: gitweb: Protect against possible warning in git_commitdiff X-Git-Tag: v1.5.0-rc0~229^2~6 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=04408c3578300ac7cc1b1530bbaec54de299b200;p=git.git gitweb: Protect against possible warning in git_commitdiff We may read an undef from <$fd> and unconditionally chomping it would result in a warning. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano --- diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 758759576..b2482febf 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3731,7 +3731,8 @@ sub git_commitdiff { $hash_parent, $hash, "--" or die_error(undef, "Open git-diff-tree failed"); - while (chomp(my $line = <$fd>)) { + while (my $line = <$fd>) { + chomp $line; # empty line ends raw part of diff-tree output last unless $line; push @difftree, $line;