From: Giuseppe Bilotta Date: Sun, 23 Aug 2009 08:28:09 +0000 (+0200) Subject: gitweb: pull ref markes pull out of subject element X-Git-Tag: v1.6.5-rc0~49 X-Git-Url: https://git.tokkee.org/?a=commitdiff_plain;h=01b89f0cd5d1c36990bbd3595b7d54c5f67d01e3;p=git.git gitweb: pull ref markes pull out of subject element Since 4afbaef (gitweb: ref markers link to named shortlogs, 2008-09-02), ref markers that accompany the subject in views such as shortlog and history point to something different from the subject itself. Therefore, they should not be included in the same element. Benefits of the change are: * better compliance to the XHTML standards, that forbid links within links even though the restriction cannot be imposed via DTD; this also benefits visualization in some older browsers; * when hovering the subject, only the subject itself is underlined; when hovering the ref markers, only the text in the hovered ref marker is underlined; previously, hovering any written part of the subject column led to complete underlying of everything at the same time, with unpleasing effects. Signed-off-by: Giuseppe Bilotta Acked-by: Jakub Narebski Signed-off-by: Junio C Hamano --- diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index be7358fde..36cf4a216 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1513,10 +1513,10 @@ sub format_subject_html { $long =~ s/[[:cntrl:]]/?/g; return $cgi->a({-href => $href, -class => "list subject", -title => to_utf8($long)}, - esc_html($short) . $extra); + esc_html($short)) . $extra; } else { return $cgi->a({-href => $href, -class => "list subject"}, - esc_html($long) . $extra); + esc_html($long)) . $extra; } }