summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0d290a4)
raw | patch | inline | side by side (parent: 0d290a4)
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
Thu, 30 Sep 2010 13:43:02 +0000 (13:43 +0000) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Thu, 30 Sep 2010 19:20:33 +0000 (12:20 -0700) |
There's no reason to explicitly stringify a variable in Perl unless
it's an overloaded object and you want to call overload::StrVal,
otherwise it's just creating a new scalar redundantly.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
it's an overloaded object and you want to call overload::StrVal,
otherwise it's just creating a new scalar redundantly.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-send-email.perl | patch | blob | history |
diff --git a/git-send-email.perl b/git-send-email.perl
index 1218bbe729ad73ebd51bf98b7e46a14c2dcccde8..1bf090a881831e86148aee857e307f762a2f8924 100755 (executable)
--- a/git-send-email.perl
+++ b/git-send-email.perl
my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/);
if (not $recipient_name) {
- return "$recipient";
+ return $recipient;
}
# if recipient_name is already quoted, do nothing