Code

make sure enum object_type is signed
authorNicolas Pitre <nico@cam.org>
Wed, 28 Feb 2007 01:38:31 +0000 (20:38 -0500)
committerJunio C Hamano <junkio@cox.net>
Wed, 28 Feb 2007 05:37:46 +0000 (21:37 -0800)
This allows for keeping the common idiom which consists of using
negative values to signal error conditions by ensuring that the enum
will be a signed type.

Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
cache.h

diff --git a/cache.h b/cache.h
index 0117b7eeddc2878c0ce7b593e06d89f276243c57..ec72c0c438e9a4cd9532bd0cd3cc0c161299bc54 100644 (file)
--- a/cache.h
+++ b/cache.h
@@ -263,6 +263,7 @@ int safe_create_leading_directories(char *path);
 char *enter_repo(char *path, int strict);
 
 enum object_type {
+       OBJ_BAD = -1,
        OBJ_NONE = 0,
        OBJ_COMMIT = 1,
        OBJ_TREE = 2,
@@ -271,7 +272,7 @@ enum object_type {
        /* 5 for future expansion */
        OBJ_OFS_DELTA = 6,
        OBJ_REF_DELTA = 7,
-       OBJ_BAD,
+       OBJ_MAX,
 };
 
 /* Read and unpack a sha1 file into memory, write memory to a sha1 file */