Code

contrib/git-svn: handle array values correctly
authorEric Wong <normalperson@yhbt.net>
Tue, 4 Apr 2006 00:41:44 +0000 (17:41 -0700)
committerJunio C Hamano <junkio@cox.net>
Tue, 4 Apr 2006 07:09:47 +0000 (00:09 -0700)
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
contrib/git-svn/git-svn.perl

index e7fff46d22df50f9c7a43e08f458eb34cd14148e..7c44450d72021a91069697826227922a841cd472 100755 (executable)
@@ -75,12 +75,11 @@ foreach my $o (keys %opts) {
        my $arg = 'git-repo-config';
        $arg .= ' --int' if ($o =~ /=i$/);
        $arg .= ' --bool' if ($o !~ /=[sfi]$/);
-       $arg .= " svn.$key"; # $key only matches [a-z\-], always shell-safe
        if (ref $v eq 'ARRAY') {
-               chomp(my @tmp = `$arg`);
+               chomp(my @tmp = `$arg --get-all svn.$key`);
                @$v = @tmp if @tmp;
        } else {
-               chomp(my $tmp = `$arg`);
+               chomp(my $tmp = `$arg --get svn.$key`);
                if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {
                        $$v = $tmp;
                }