Code

--summary output should print immediately after stats.
authorSean <seanlkml@sympatico.ca>
Tue, 23 May 2006 09:34:23 +0000 (05:34 -0400)
committerJunio C Hamano <junkio@cox.net>
Wed, 24 May 2006 06:45:37 +0000 (23:45 -0700)
Currently the summary is displayed after the patch.  Fix this so
that the output order is stat-summary-patch.  As a consequence of
the way this is coded, the --summary option will only actually
display summary data if combined with either the --stat or
--patch-with-stat option.

Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca>
Signed-off-by: Junio C Hamano <junkio@cox.net>
diff.c

diff --git a/diff.c b/diff.c
index 3a2a175c7ec34d5524f8e664c4dd3f05c24f4d4a..77c09a87b0742376784d2563221763ffd4c6934e 100644 (file)
--- a/diff.c
+++ b/diff.c
@@ -1988,6 +1988,9 @@ void diff_flush(struct diff_options *options)
                show_stats(diffstat);
                free(diffstat);
                diffstat = NULL;
+               if (options->summary)
+                       for (i = 0; i < q->nr; i++)
+                               diff_summary(q->queue[i]);
                putchar(options->line_termination);
        }
        for (i = 0; i < q->nr; i++) {
@@ -2001,7 +2004,7 @@ void diff_flush(struct diff_options *options)
        }
 
        for (i = 0; i < q->nr; i++) {
-               if (options->summary)
+               if (diffstat && options->summary)
                        diff_summary(q->queue[i]);
                diff_free_filepair(q->queue[i]);
        }