Code

email plugin: Fix "Dead assignment" warning.
authorFlorian Forster <octo@collectd.org>
Thu, 18 Jun 2015 07:16:18 +0000 (09:16 +0200)
committerFlorian Forster <octo@collectd.org>
Thu, 18 Jun 2015 07:25:38 +0000 (09:25 +0200)
src/email.c

index 4aac3e312e8d94272afcdb830cc0365833ad2a74..fdcf0677837e25cb27e50e78ad6c69f17be7bc3c 100644 (file)
@@ -251,8 +251,6 @@ static void *collect (void *arg)
        collector_t *this = (collector_t *)arg;
 
        while (1) {
-               int loop = 1;
-
                conn_t *connection;
 
                pthread_mutex_lock (&conns_mutex);
@@ -277,15 +275,13 @@ static void *collect (void *arg)
                log_debug ("collect: handling connection on fd #%i",
                                fileno (this->socket));
 
-               while (loop) {
+               while (42) {
                        /* 256 bytes ought to be enough for anybody ;-) */
                        char line[256 + 1]; /* line + '\0' */
                        int  len = 0;
 
                        errno = 0;
                        if (NULL == fgets (line, sizeof (line), this->socket)) {
-                               loop = 0;
-
                                if (0 != errno) {
                                        char errbuf[1024];
                                        log_err ("collect: reading from socket (fd #%i) "
@@ -358,7 +354,7 @@ static void *collect (void *arg)
                        else {
                                log_err ("collect: unknown type '%c'", line[0]);
                        }
-               } /* while (loop) */
+               } /* while (42) */
 
                log_debug ("Shutting down connection on fd #%i",
                                fileno (this->socket));