Code

zfs_arc plugin: Avoid resetting global variables from init().
authorFlorian Forster <octo@collectd.org>
Mon, 25 Sep 2017 07:28:34 +0000 (09:28 +0200)
committerFlorian Forster <octo@collectd.org>
Mon, 25 Sep 2017 07:28:34 +0000 (09:28 +0200)
Fixes: #973
src/zfs_arc.c

index 3ef3e562c79e91c6aa78cb63a464588bcc589c4f..e589184c2cf0fe6b898762270a47462c33d299fa 100644 (file)
 /*
  * Global variables
  */
+static value_to_rate_state_t arc_hits_state;
+static value_to_rate_state_t arc_misses_state;
+static value_to_rate_state_t l2_hits_state;
+static value_to_rate_state_t l2_misses_state;
 
 #if defined(KERNEL_LINUX)
 #include "utils_llist.h"
@@ -188,9 +192,6 @@ static void za_submit_ratio(const char *type_instance, gauge_t hits,
   za_submit_gauge("cache_ratio", type_instance, ratio);
 }
 
-static value_to_rate_state_t arc_hits_state, arc_misses_state, l2_hits_state,
-    l2_misses_state;
-
 static int za_read(void) {
   gauge_t arc_hits, arc_misses, l2_hits, l2_misses;
   kstat_t *ksp = NULL;
@@ -361,11 +362,6 @@ static int za_init(void) /* {{{ */
   }
 #endif
 
-  memset(&arc_hits_state, 0, sizeof(arc_hits_state));
-  memset(&arc_misses_state, 0, sizeof(arc_misses_state));
-  memset(&l2_hits_state, 0, sizeof(l2_hits_state));
-  memset(&l2_misses_state, 0, sizeof(l2_misses_state));
-
   return 0;
 } /* }}} int za_init */