Code

gitweb: Use rev-list --skip option.
authorRobert Fitzsimons <robfitz@273k.net>
Sun, 24 Dec 2006 14:31:49 +0000 (14:31 +0000)
committerJunio C Hamano <junkio@cox.net>
Mon, 25 Dec 2006 18:40:44 +0000 (10:40 -0800)
Signed-off-by: Robert Fitzsimons <robfitz@273k.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
gitweb/gitweb.perl

index f9994d941740107855dc49b7276619193dd20a90..65fcdb0f289c21b0824546884d826b48586ca712 100755 (executable)
@@ -1391,35 +1391,13 @@ sub parse_commits {
        $maxcount ||= 1;
        $skip ||= 0;
 
-       # Delete once rev-list supports the --skip option
-       if ($skip > 0) {
-               open my $fd, "-|", git_cmd(), "rev-list",
-                       ($arg ? ($arg) : ()),
-                       ("--max-count=" . ($maxcount + $skip)),
-                       $commit_id,
-                       "--",
-                       ($filename ? ($filename) : ())
-                       or die_error(undef, "Open git-rev-list failed");
-               while (my $line = <$fd>) {
-                       if ($skip-- <= 0) {
-                               chomp $line;
-                               my %co = parse_commit($line);
-                               push @cos, \%co;
-                       }
-               }
-               close $fd;
-
-               return wantarray ? @cos : \@cos;
-       }
-
        local $/ = "\0";
 
        open my $fd, "-|", git_cmd(), "rev-list",
                "--header",
                ($arg ? ($arg) : ()),
                ("--max-count=" . $maxcount),
-               # Add once rev-list supports the --skip option
-               # ("--skip=" . $skip),
+               ("--skip=" . $skip),
                $commit_id,
                "--",
                ($filename ? ($filename) : ())