Code

submodule add: clean up duplicated code
authorJens Lehmann <Jens.Lehmann@web.de>
Mon, 6 Jun 2011 19:58:43 +0000 (21:58 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 6 Jun 2011 20:46:36 +0000 (13:46 -0700)
In cmd_add() the switch statement used to resolve a relative url was
present twice. Remove the second one and use the realrepo variable set
by the first one (lines 194 ff.) instead.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-submodule.sh

index 0c984a898320ef495544b1d8bb7602aefe647447..32cb05443a851e7bd77d86b3bb3b2f7962c4d53b 100755 (executable)
@@ -238,15 +238,7 @@ cmd_add()
                        die "'$path' already exists and is not a valid git repo"
                fi
 
-               case "$repo" in
-               ./*|../*)
-                       url=$(resolve_relative_url "$repo") || exit
-                   ;;
-               *)
-                       url="$repo"
-                       ;;
-               esac
-               git config submodule."$path".url "$url"
+               git config submodule."$path".url "$realrepo"
        else
 
                module_clone "$path" "$realrepo" "$reference" || exit