Code

Merge branch 'jc/am-3-show-corrupted-patch'
authorJunio C Hamano <gitster@pobox.com>
Fri, 21 May 2010 11:02:18 +0000 (04:02 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 21 May 2010 11:02:18 +0000 (04:02 -0700)
* jc/am-3-show-corrupted-patch:
  am -3: recover the diagnostic messages for corrupt patches

1  2 
git-am.sh

diff --combined git-am.sh
index 1056075545ad3e5e42626d167c91c1deada6186b,4e0e40677c4583fe65a3c503115dca16a515ad81..87ffae252b3f2ff88646d142ea9c2dfb38a28953
+++ b/git-am.sh
@@@ -11,29 -11,20 +11,29 @@@ git am [options] (--resolved | --skip 
  i,interactive   run interactively
  b,binary*       (historical option -- no-op)
  3,3way          allow fall back on 3way merging if needed
 +q,quiet         be quiet
  s,signoff       add a Signed-off-by line to the commit message
  u,utf8          recode into utf8 (default)
  k,keep          pass -k flag to git-mailinfo
 +keep-cr         pass --keep-cr flag to git-mailsplit for mbox format
 +no-keep-cr      do not pass --keep-cr flag to git-mailsplit independent of am.keepcr
 +c,scissors      strip everything before a scissors line
  whitespace=     pass it through git-apply
 +ignore-space-change pass it through git-apply
 +ignore-whitespace pass it through git-apply
  directory=      pass it through git-apply
  C=              pass it through git-apply
  p=              pass it through git-apply
 +patch-format=   format the patch(es) are in
  reject          pass it through git-apply
  resolvemsg=     override error message when patch failure occurs
 -r,resolved      to be used after a patch failure
 +continue        continue applying patches after resolving a conflict
 +r,resolved      synonyms for --continue
  skip            skip the current patch
  abort           restore the original branch and abort the patching operation.
  committer-date-is-author-date    lie about committer date
  ignore-date     use current timestamp for author date
 +rerere-autoupdate update the index with reused conflict resolution if possible
  rebasing*       (internal use for git-rebase)"
  
  . git-sh-setup
@@@ -108,7 -99,7 +108,7 @@@ fall_back_3way () 
      git write-tree >"$dotest/patch-merge-base+" ||
      cannot_fallback "Repository lacks necessary blobs to fall back on 3-way merge."
  
 -    echo Using index info to reconstruct a base tree...
 +    say Using index info to reconstruct a base tree...
      if GIT_INDEX_FILE="$dotest/patch-merge-tmp-index" \
        git apply --cached <"$dotest/patch"
      then
@@@ -124,7 -115,7 +124,7 @@@ It does not apply to blobs recorded in 
      orig_tree=$(cat "$dotest/patch-merge-base") &&
      rm -fr "$dotest"/patch-merge-* || exit 1
  
 -    echo Falling back to patching base and 3-way merge...
 +    say Falling back to patching base and 3-way merge...
  
      # This is not so wrong.  Depending on which base we picked,
      # orig_tree may be wildly different from ours, but his_tree
  
      eval GITHEAD_$his_tree='"$FIRSTLINE"'
      export GITHEAD_$his_tree
 +    if test -n "$GIT_QUIET"
 +    then
 +          export GIT_MERGE_VERBOSITY=0
 +    fi
      git-merge-recursive $orig_tree -- HEAD $his_tree || {
 -          git rerere
 +          git rerere $allow_rerere_autoupdate
            echo Failed to merge in the changes.
            exit 1
      }
      unset GITHEAD_$his_tree
  }
  
 +clean_abort () {
 +      test $# = 0 || echo >&2 "$@"
 +      rm -fr "$dotest"
 +      exit 1
 +}
 +
 +patch_format=
 +
 +check_patch_format () {
 +      # early return if patch_format was set from the command line
 +      if test -n "$patch_format"
 +      then
 +              return 0
 +      fi
 +
 +      # we default to mbox format if input is from stdin and for
 +      # directories
 +      if test $# = 0 || test "x$1" = "x-" || test -d "$1"
 +      then
 +              patch_format=mbox
 +              return 0
 +      fi
 +
 +      # otherwise, check the first few lines of the first patch to try
 +      # to detect its format
 +      {
 +              read l1
 +              read l2
 +              read l3
 +              case "$l1" in
 +              "From "* | "From: "*)
 +                      patch_format=mbox
 +                      ;;
 +              '# This series applies on GIT commit'*)
 +                      patch_format=stgit-series
 +                      ;;
 +              "# HG changeset patch")
 +                      patch_format=hg
 +                      ;;
 +              *)
 +                      # if the second line is empty and the third is
 +                      # a From, Author or Date entry, this is very
 +                      # likely an StGIT patch
 +                      case "$l2,$l3" in
 +                      ,"From: "* | ,"Author: "* | ,"Date: "*)
 +                              patch_format=stgit
 +                              ;;
 +                      *)
 +                              ;;
 +                      esac
 +                      ;;
 +              esac
 +              if test -z "$patch_format" &&
 +                      test -n "$l1" &&
 +                      test -n "$l2" &&
 +                      test -n "$l3"
 +              then
 +                      # This begins with three non-empty lines.  Is this a
 +                      # piece of e-mail a-la RFC2822?  Grab all the headers,
 +                      # discarding the indented remainder of folded lines,
 +                      # and see if it looks like that they all begin with the
 +                      # header field names...
 +                      tr -d '\015' <"$1" |
 +                      sed -n -e '/^$/q' -e '/^[       ]/d' -e p |
 +                      sane_egrep -v '^[!-9;-~]+:' >/dev/null ||
 +                      patch_format=mbox
 +              fi
 +      } < "$1" || clean_abort
 +}
 +
 +split_patches () {
 +      case "$patch_format" in
 +      mbox)
 +              if test -n "$rebasing" || test t = "$keepcr"
 +              then
 +                  keep_cr=--keep-cr
 +              else
 +                  keep_cr=
 +              fi
 +              git mailsplit -d"$prec" -o"$dotest" -b $keep_cr -- "$@" > "$dotest/last" ||
 +              clean_abort
 +              ;;
 +      stgit-series)
 +              if test $# -ne 1
 +              then
 +                      clean_abort "Only one StGIT patch series can be applied at once"
 +              fi
 +              series_dir=`dirname "$1"`
 +              series_file="$1"
 +              shift
 +              {
 +                      set x
 +                      while read filename
 +                      do
 +                              set "$@" "$series_dir/$filename"
 +                      done
 +                      # remove the safety x
 +                      shift
 +                      # remove the arg coming from the first-line comment
 +                      shift
 +              } < "$series_file" || clean_abort
 +              # set the patch format appropriately
 +              patch_format=stgit
 +              # now handle the actual StGIT patches
 +              split_patches "$@"
 +              ;;
 +      stgit)
 +              this=0
 +              for stgit in "$@"
 +              do
 +                      this=`expr "$this" + 1`
 +                      msgnum=`printf "%0${prec}d" $this`
 +                      # Perl version of StGIT parse_patch. The first nonemptyline
 +                      # not starting with Author, From or Date is the
 +                      # subject, and the body starts with the next nonempty
 +                      # line not starting with Author, From or Date
 +                      perl -ne 'BEGIN { $subject = 0 }
 +                              if ($subject > 1) { print ; }
 +                              elsif (/^\s+$/) { next ; }
 +                              elsif (/^Author:/) { print s/Author/From/ ; }
 +                              elsif (/^(From|Date)/) { print ; }
 +                              elsif ($subject) {
 +                                      $subject = 2 ;
 +                                      print "\n" ;
 +                                      print ;
 +                              } else {
 +                                      print "Subject: ", $_ ;
 +                                      $subject = 1;
 +                              }
 +                      ' < "$stgit" > "$dotest/$msgnum" || clean_abort
 +              done
 +              echo "$this" > "$dotest/last"
 +              this=
 +              msgnum=
 +              ;;
 +      *)
 +              if test -n "$parse_patch" ; then
 +                      clean_abort "Patch format $patch_format is not supported."
 +              else
 +                      clean_abort "Patch format detection failed."
 +              fi
 +              ;;
 +      esac
 +}
 +
  prec=4
  dotest="$GIT_DIR/rebase-apply"
 -sign= utf8=t keep= skip= interactive= resolved= rebasing= abort=
 -resolvemsg= resume=
 +sign= utf8=t keep= keepcr= skip= interactive= resolved= rebasing= abort=
 +resolvemsg= resume= scissors= no_inbody_headers=
  git_apply_opt=
  committer_date_is_author_date=
  ignore_date=
 +allow_rerere_autoupdate=
 +
 +if test "$(git config --bool --get am.keepcr)" = true
 +then
 +    keepcr=t
 +fi
  
  while test $# != 0
  do
                utf8= ;;
        -k|--keep)
                keep=t ;;
 -      -r|--resolved)
 +      -c|--scissors)
 +              scissors=t ;;
 +      --no-scissors)
 +              scissors=f ;;
 +      -r|--resolved|--continue)
                resolved=t ;;
        --skip)
                skip=t ;;
        --abort)
                abort=t ;;
        --rebasing)
 -              rebasing=t threeway=t keep=t ;;
 +              rebasing=t threeway=t keep=t scissors=f no_inbody_headers=t ;;
        -d|--dotest)
                die "-d option is no longer supported.  Do not use."
                ;;
                git_apply_opt="$git_apply_opt $(sq "$1=$2")"; shift ;;
        -C|-p)
                git_apply_opt="$git_apply_opt $(sq "$1$2")"; shift ;;
 -      --reject)
 +      --patch-format)
 +              shift ; patch_format="$1" ;;
 +      --reject|--ignore-whitespace|--ignore-space-change)
                git_apply_opt="$git_apply_opt $1" ;;
        --committer-date-is-author-date)
                committer_date_is_author_date=t ;;
        --ignore-date)
                ignore_date=t ;;
 +      --rerere-autoupdate|--no-rerere-autoupdate)
 +              allow_rerere_autoupdate="$1" ;;
 +      -q|--quiet)
 +              GIT_QUIET=t ;;
 +      --keep-cr)
 +              keepcr=t ;;
 +      --no-keep-cr)
 +              keepcr=f ;;
        --)
                shift; break ;;
        *)
@@@ -452,22 -274,19 +452,22 @@@ els
                done
                shift
        fi
 -      git mailsplit -d"$prec" -o"$dotest" -b -- "$@" > "$dotest/last" ||  {
 -              rm -fr "$dotest"
 -              exit 1
 -      }
  
 -      # -s, -u, -k, --whitespace, -3, -C and -p flags are kept
 -      # for the resuming session after a patch failure.
 -      # -i can and must be given when resuming.
 +      check_patch_format "$@"
 +
 +      split_patches "$@"
 +
 +      # -i can and must be given when resuming; everything
 +      # else is kept
        echo " $git_apply_opt" >"$dotest/apply-opt"
        echo "$threeway" >"$dotest/threeway"
        echo "$sign" >"$dotest/sign"
        echo "$utf8" >"$dotest/utf8"
        echo "$keep" >"$dotest/keep"
 +      echo "$keepcr" >"$dotest/keepcr"
 +      echo "$scissors" >"$dotest/scissors"
 +      echo "$no_inbody_headers" >"$dotest/no_inbody_headers"
 +      echo "$GIT_QUIET" >"$dotest/quiet"
        echo 1 >"$dotest/next"
        if test -n "$rebasing"
        then
@@@ -508,28 -327,6 +508,28 @@@ if test "$(cat "$dotest/keep")" = 
  then
        keep=-k
  fi
 +case "$(cat "$dotest/keepcr")" in
 +t)
 +      keepcr=--keep-cr ;;
 +f)
 +      keepcr=--no-keep-cr ;;
 +esac
 +case "$(cat "$dotest/scissors")" in
 +t)
 +      scissors=--scissors ;;
 +f)
 +      scissors=--no-scissors ;;
 +esac
 +if test "$(cat "$dotest/no_inbody_headers")" = t
 +then
 +      no_inbody_headers=--no-inbody-headers
 +else
 +      no_inbody_headers=
 +fi
 +if test "$(cat "$dotest/quiet")" = t
 +then
 +      GIT_QUIET=t
 +fi
  if test "$(cat "$dotest/threeway")" = t
  then
        threeway=t
@@@ -555,7 -352,7 +555,7 @@@ f
  
  if test "$this" -gt "$last"
  then
 -      echo Nothing to do.
 +      say Nothing to do.
        rm -fr "$dotest"
        exit
  fi
        # by the user, or the user can tell us to do so by --resolved flag.
        case "$resume" in
        '')
 -              git mailinfo $keep $utf8 "$dotest/msg" "$dotest/patch" \
 +              git mailinfo $keep $no_inbody_headers $scissors $utf8 "$dotest/msg" "$dotest/patch" \
                        <"$dotest/$msgnum" >"$dotest/info" ||
                        stop_here $this
  
                # skip pine's internal folder data
 -              grep '^Author: Mail System Internal Data$' \
 +              sane_grep '^Author: Mail System Internal Data$' \
                        <"$dotest"/info >/dev/null &&
                        go_next && continue
  
                        echo "Patch is empty.  Was it split wrong?"
                        stop_here $this
                }
 +              rm -f "$dotest/original-commit"
                if test -f "$dotest/rebasing" &&
                        commit=$(sed -e 's/^From \([0-9a-f]*\) .*/\1/' \
                                -e q "$dotest/$msgnum") &&
                then
                        git cat-file commit "$commit" |
                        sed -e '1,/^$/d' >"$dotest/msg-clean"
 +                      echo "$commit" > "$dotest/original-commit"
                else
 -                      SUBJECT="$(sed -n '/^Subject/ s/Subject: //p' "$dotest/info")"
 -                      case "$keep_subject" in -k)  SUBJECT="[PATCH] $SUBJECT" ;; esac
 -
 -                      (printf '%s\n\n' "$SUBJECT"; cat "$dotest/msg") |
 -                              git stripspace > "$dotest/msg-clean"
 +                      {
 +                              sed -n '/^Subject/ s/Subject: //p' "$dotest/info"
 +                              echo
 +                              cat "$dotest/msg"
 +                      } |
 +                      git stripspace > "$dotest/msg-clean"
                fi
                ;;
        esac
                [eE]*) git_editor "$dotest/final-commit"
                       action=again ;;
                [vV]*) action=again
 -                     LESS=-S ${PAGER:-less} "$dotest/patch" ;;
 +                     git_pager "$dotest/patch" ;;
                *)     action=again ;;
                esac
            done
                stop_here $this
        fi
  
 -      printf 'Applying: %s\n' "$FIRSTLINE"
 +      say "Applying: $FIRSTLINE"
  
        case "$resolved" in
        '')
                ;;
        esac
  
-       if test $apply_status = 1 && test "$threeway" = t
+       if test $apply_status != 0 && test "$threeway" = t
        then
                if (fall_back_3way)
                then
                    # Applying the patch to an earlier tree and merging the
                    # result may have produced the same tree as ours.
                    git diff-index --quiet --cached HEAD -- && {
 -                      echo No changes -- Patch already applied.
 +                      say No changes -- Patch already applied.
                        go_next
                        continue
                    }
                        GIT_AUTHOR_DATE=
                fi
                parent=$(git rev-parse --verify -q HEAD) ||
 -              echo >&2 "applying to an empty history"
 +              say >&2 "applying to an empty history"
  
                if test -n "$committer_date_is_author_date"
                then
        git update-ref -m "$GIT_REFLOG_ACTION: $FIRSTLINE" HEAD $commit $parent ||
        stop_here $this
  
 +      if test -f "$dotest/original-commit"; then
 +              echo "$(cat "$dotest/original-commit") $commit" >> "$dotest/rewritten"
 +      fi
 +
        if test -x "$GIT_DIR"/hooks/post-applypatch
        then
                "$GIT_DIR"/hooks/post-applypatch
        go_next
  done
  
 -git gc --auto
 +if test -s "$dotest"/rewritten; then
 +    git notes copy --for-rewrite=rebase < "$dotest"/rewritten
 +    if test -x "$GIT_DIR"/hooks/post-rewrite; then
 +      "$GIT_DIR"/hooks/post-rewrite rebase < "$dotest"/rewritten
 +    fi
 +fi
  
  rm -fr "$dotest"
 +git gc --auto