Fixed post handling.

git-svn-id: https://oss.gonicus.de/repositories/gosa/trunk@19094 594d385d-05f5-0310-b6e9-bd551577e9d8

diff --git a/gosa-plugins/gofon/admin/systems/gofon/class_phoneGeneric.inc b/gosa-plugins/gofon/admin/systems/gofon/class_phoneGeneric.inc
index 5e4115545a93080c558d68015d4a1c5e19ecf328..992fab7d7cf4392695d2d175c88378ce5e87f571 100644 (file)
--- a/gosa-plugins/gofon/admin/systems/gofon/class_phoneGeneric.inc
+++ b/gosa-plugins/gofon/admin/systems/gofon/class_phoneGeneric.inc
@@ -2,534 +2,538 @@
 
 class phoneGeneric extends plugin
 {
-  /* Generic terminal attributes */
-  var $interfaces= array();
-  var $ignore_account= TRUE;
-
-  /* Needed values and lists */
-  var $base             = "";
-  var $cn               = "";
-  var $description      = "";
-  var $orig_dn          = "";
-  var $orig_cn          = "";
-  var $orig_base        = "";
-  var $goFonType        = "";
-  var $goFonDmtfMode    = "";
-  var $goFonHost        = "";
-  var $goFonDefaultIP   = "dynamic";
-  var $goFonQualify     = "";
-  var $goFonAuth        = "";
-  var $goFonSecret      = "";
-  var $goFonInkeys      = "";
-  var $goFonPermit      = array();
-  var $goFonDeny        = array();
-  var $goFonOutkey      = "";
-  var $goFonTrunk       = "";
-  var $goFonAccountCode = "";
-  var $goFonMSN         = "";
-  var $selected_categorie    = 0;
-  var $netConfigDNS;
-  var $view_logged      = FALSE;
-  var $baseSelector;
-
-  /* attribute list for save action */
-  var $attributes= array("cn", "description",
-                          "goFonType","goFonDmtfMode","goFonHost","goFonDefaultIP",
-                          "goFonQualify","goFonAuth","goFonSecret","goFonInkeys","goFonOutkey",
-                          "goFonTrunk","goFonAccountCode","goFonMSN","selected_categorie","goFonPermit","goFonDeny" 
-                         );
-
-  /* this array defines which attributes are schown / saved for the different type of phones */ 
-  var $usedattrs =    array( "0"=>array("cn", "description", 
-                                  "goFonType","goFonDmtfMode","goFonHost","goFonDefaultIP",
-                                  "goFonQualify"),
-                             "1"=>array("cn", "description", 
-                                  "goFonType","goFonHost","goFonDefaultIP",
-                                  "goFonQualify","goFonAuth","goFonSecret","goFonInkeys","goFonOutkey",
-                                  "goFonTrunk","goFonAccountCode","selected_categorie","goFonPermit","goFonDeny"),
-                             "2"=>array("cn", "description", "goFonMSN"));
-  
-
-  var $objectclasses= array("top", "goFonHardware");
-
-  function phoneGeneric (&$config, $dn= NULL, $parent= NULL)
-  {
-    plugin::plugin ($config, $dn, $parent);
-    $this->netConfigDNS = new termDNS($this->config,$this,$this->objectclasses, true);
-    $this->netConfigDNS->MACisMust =TRUE;
-
-    /* Set base */
-    if ($this->dn == "new"){
-      $ui= get_userinfo();
-      $this->base= dn2base(session::global_is_set("CurrentMainBase")?"cn=dummy,".session::global_get("CurrentMainBase"):$ui->dn);
-      $this->cn= "";
-    } else {
-      $this->base= preg_replace ("/^[^,]+,".preg_quote(get_ou("phoneGeneric", "phoneRDN"), '/')."/i", "", $this->dn);
-    }
-  
-    if($this->goFonMSN != ""){
-      $this->selected_categorie = 2;
-    }elseif($this->goFonAccountCode != ""){
-      $this->selected_categorie = 1 ;
-    
-      if(isset($this->attrs['goFonPermit']['count'])){
-        unset ($this->attrs['goFonPermit']['count']);
-        $this->goFonPermit=$this->attrs['goFonPermit'];
-      }  
-     
-      if(isset($this->attrs['goFonDeny']['count'])){
-        unset ($this->attrs['goFonDeny']['count'])   ;
-        $this->goFonDeny=$this->attrs['goFonDeny'];
-      } 
-
-    } else {
-      $this->selected_categorie = 0;
-    }
+    /* Generic terminal attributes */
+    var $interfaces= array();
+    var $ignore_account= TRUE;
+
+    /* Needed values and lists */
+    var $base             = "";
+    var $cn               = "";
+    var $description      = "";
+    var $orig_dn          = "";
+    var $orig_cn          = "";
+    var $orig_base        = "";
+    var $goFonType        = "";
+    var $goFonDmtfMode    = "";
+    var $goFonHost        = "";
+    var $goFonDefaultIP   = "dynamic";
+    var $goFonQualify     = "";
+    var $goFonAuth        = "";
+    var $goFonSecret      = "";
+    var $goFonInkeys      = "";
+    var $goFonPermit      = array();
+    var $goFonDeny        = array();
+    var $goFonOutkey      = "";
+    var $goFonTrunk       = "";
+    var $goFonAccountCode = "";
+    var $goFonMSN         = "";
+    var $selected_category    = 0;
+    var $netConfigDNS;
+    var $view_logged      = FALSE;
+    var $baseSelector;
+
+    /* attribute list for save action */
+    var $attributes= array("cn", "description",
+            "goFonType","goFonDmtfMode","goFonHost","goFonDefaultIP",
+            "goFonQualify","goFonAuth","goFonSecret","goFonInkeys","goFonOutkey",
+            "goFonTrunk","goFonAccountCode","goFonMSN","selected_category","goFonPermit","goFonDeny" 
+            );
+
+    /* this array defines which attributes are schown / saved for the different type of phones */ 
+    var $usedattrs =    array( "0"=>array("cn", "description", 
+                "goFonType","goFonDmtfMode","goFonHost","goFonDefaultIP",
+                "goFonQualify"),
+            "1"=>array("cn", "description", 
+                "goFonType","goFonHost","goFonDefaultIP",
+                "goFonQualify","goFonAuth","goFonSecret","goFonInkeys","goFonOutkey",
+                "goFonTrunk","goFonAccountCode","selected_category","goFonPermit","goFonDeny"),
+            "2"=>array("cn", "description", "goFonMSN"));
+
+
+    var $objectclasses= array("top", "goFonHardware");
+
+    function phoneGeneric (&$config, $dn= NULL, $parent= NULL)
+    {
+        plugin::plugin ($config, $dn, $parent);
+        $this->netConfigDNS = new termDNS($this->config,$this,$this->objectclasses, true);
+        $this->netConfigDNS->MACisMust =TRUE;
+
+        /* Set base */
+        if ($this->dn == "new"){
+            $ui= get_userinfo();
+            $this->base= dn2base(session::global_is_set("CurrentMainBase")?"cn=dummy,".session::global_get("CurrentMainBase"):$ui->dn);
+            $this->cn= "";
+        } else {
+            $this->base= preg_replace ("/^[^,]+,".preg_quote(get_ou("phoneGeneric", "phoneRDN"), '/')."/i", "", $this->dn);
+        }
+
+        if($this->goFonMSN != ""){
+            $this->selected_category = 2;
+        }elseif($this->goFonAccountCode != ""){
+            $this->selected_category = 1 ;
+
+            if(isset($this->attrs['goFonPermit']['count'])){
+                unset ($this->attrs['goFonPermit']['count']);
+                $this->goFonPermit=$this->attrs['goFonPermit'];
+            }  
+
+            if(isset($this->attrs['goFonDeny']['count'])){
+                unset ($this->attrs['goFonDeny']['count'])   ;
+                $this->goFonDeny=$this->attrs['goFonDeny'];
+            } 
+
+        } else {
+            $this->selected_category = 0;
+        }
+
+        if($this->goFonDefaultIP!="dynamic"){
+            $this->goFonDefaultIP = "network";
+        }
+
+        /* Save dn for later references */
+        $this->orig_dn= $this->dn;
+        $this->orig_base= $this->base;
+        $this->orig_cn= $this->cn;
 
-    if($this->goFonDefaultIP!="dynamic"){
-      $this->goFonDefaultIP = "network";
+        /* Instanciate base selector */
+        $this->baseSelector= new baseSelector($this->get_allowed_bases(), $this->base);
+        $this->baseSelector->setSubmitButton(false);
+        $this->baseSelector->setHeight(300);
+        $this->baseSelector->update(true);
     }
 
-    /* Save dn for later references */
-    $this->orig_dn= $this->dn;
-    $this->orig_base= $this->base;
-    $this->orig_cn= $this->cn;
-
-    /* Instanciate base selector */
-    $this->baseSelector= new baseSelector($this->get_allowed_bases(), $this->base);
-    $this->baseSelector->setSubmitButton(false);
-    $this->baseSelector->setHeight(300);
-    $this->baseSelector->update(true);
-  }
-
-  function set_acl_base($base)
-  {
-    plugin::set_acl_base($base);
-    $this->netConfigDNS->set_acl_base($base);
-  }
-
-  function set_acl_category($cat)
-  {
-    plugin::set_acl_category($cat);
-    $this->netConfigDNS->set_acl_category($cat);
-  }
-
-
-  function execute()
-  {
-    /* Call parent execute */
-    plugin::execute();
-
-    if($this->is_account && !$this->view_logged){
-      $this->view_logged = TRUE;
-      new log("view","phone/".get_class($this),$this->dn);
+    function set_acl_base($base)
+    {
+        plugin::set_acl_base($base);
+        $this->netConfigDNS->set_acl_base($base);
     }
 
-    /* Do we represent a valid phone? */
-    if (!$this->is_account && $this->parent === NULL){
-      $display= "<img alt=\"\" src=\"images/small-error.png\" align=middle>&nbsp;<b>".
-        msgPool::noValidExtension(_("phone"))."</b>";
-      return($display);
+    function set_acl_category($cat)
+    {
+        plugin::set_acl_category($cat);
+        $this->netConfigDNS->set_acl_category($cat);
     }
 
-    /* handle Permit Add*/
-    if(isset($_POST['goFonPermitAdd']) && $this->acl_is_writeable("goFonPermit")){
-      if(isset($_POST['goFonPermitNew'])){
-        if(is_string($this->goFonPermit)){
-          $this->goFonPermit=array();
+
+    function execute()
+    {
+        /* Call parent execute */
+        plugin::execute();
+
+        if($this->is_account && !$this->view_logged){
+            $this->view_logged = TRUE;
+            new log("view","phone/".get_class($this),$this->dn);
         }
-        $new = $_POST['goFonPermitNew'];
-        if(strlen($new)> 1) {
-          $this->goFonPermit[]= $new;
+
+        /* Do we represent a valid phone? */
+        if (!$this->is_account && $this->parent === NULL){
+            $display= "<img alt=\"\" src=\"images/small-error.png\" align=middle>&nbsp;<b>".
+                msgPool::noValidExtension(_("phone"))."</b>";
+            return($display);
         }
-      }
-    }
-      
-    /* handle Deny Add*/
-    if(isset($_POST['goFonDenyAdd']) && $this->acl_is_writeable("goFonDeny")){
-      if(isset($_POST['goFonDenyNew'])){
-        if(is_string($this->goFonDeny)){
-          $this->goFonDeny=array();
+
+        /* handle Permit Add*/
+        if(isset($_POST['goFonPermitAdd']) && $this->acl_is_writeable("goFonPermit")){
+            if(isset($_POST['goFonPermitNew'])){
+                if(is_string($this->goFonPermit)){
+                    $this->goFonPermit=array();
+                }
+                $new = get_post('goFonPermitNew');
+                if(strlen($new)> 1) {
+                    $this->goFonPermit[]= $new;
+                }
+            }
         }
-        $new = $_POST['goFonDenyNew'];
-        if(strlen($new)> 1) {
-          $this->goFonDeny[]= $new;
+
+        /* handle Deny Add*/
+        if(isset($_POST['goFonDenyAdd']) && $this->acl_is_writeable("goFonDeny")){
+            if(isset($_POST['goFonDenyNew'])){
+                if(is_string($this->goFonDeny)){
+                    $this->goFonDeny=array();
+                }
+                $new = get_post('goFonDenyNew');
+                if(strlen($new)> 1) {
+                    $this->goFonDeny[]= $new;
+                }
+            }
         }
-      }
-    }
 
-    /* Handle Permit Deletion*/
-    if(isset($_POST['goFonPermitDel']) && $this->acl_is_writeable("goFonPermit")){
-      if(isset($_POST['goFonPermitS'])){
-        if(is_string($this->goFonPermit)){
-          $this->goFonPermit=array();
+        /* Handle Permit Deletion*/
+        if(isset($_POST['goFonPermitDel']) && $this->acl_is_writeable("goFonPermit")){
+            if(isset($_POST['goFonPermitS'])){
+                if(is_string($this->goFonPermit)){
+                    $this->goFonPermit=array();
+                }
+                $new = get_post('goFonPermitS');
+                $tmp = array_flip($this->goFonPermit);
+                unset($tmp[$new]);
+                $this->goFonPermit=array();
+                foreach(array_flip($tmp) as $tm){
+                    $this->goFonPermit[]=$tm;
+                }
+            }
         }
-        $new = $_POST['goFonPermitS'];
-        $tmp = array_flip($this->goFonPermit);
-        unset($tmp[$new]);
-        $this->goFonPermit=array();
-        foreach(array_flip($tmp) as $tm){
-          $this->goFonPermit[]=$tm;
+
+
+        /* Handle Permit Deletion*/
+        if(isset($_POST['goFonDenyDel']) && $this->acl_is_writeable("goFonDeny")){
+            if(isset($_POST['goFonDenyS'])){
+                if(is_string($this->goFonDeny)){
+                    $this->goFonDeny=array();
+                }
+                $new = get_post('goFonDenyS');
+                $tmp = array_flip($this->goFonDeny);
+                unset($tmp[$new]);
+                $this->goFonDeny=array();
+                foreach(array_flip($tmp) as $tm){
+                    $this->goFonDeny[]=$tm;
+                }
+            }
         }
-      }
-    }
 
+        /* Fill templating stuff */
+        $smarty= get_smarty();
 
-    /* Handle Permit Deletion*/
-    if(isset($_POST['goFonDenyDel']) && $this->acl_is_writeable("goFonDeny")){
-      if(isset($_POST['goFonDenyS'])){
-        if(is_string($this->goFonDeny)){
-          $this->goFonDeny=array();
+
+        $tmp = $this->plInfo();
+        foreach($tmp['plProvidedAcls'] as $name => $translation){
+            $smarty->assign($name."ACL",$this->getacl($name));
         }
-        $new = $_POST['goFonDenyS'];
-        $tmp = array_flip($this->goFonDeny);
-        unset($tmp[$new]);
-        $this->goFonDeny=array();
-        foreach(array_flip($tmp) as $tm){
-          $this->goFonDeny[]=$tm;
+
+        /* Create Arrays for samrty select boxes */
+        $smarty->assign("categorys",    set_post(array("SIP","IAX","CAPI")));
+        $smarty->assign("goFonTypes",    set_post(array("peer"      =>"peer"      ,"user"   =>"user"    ,"friend" =>"friend")));
+        $smarty->assign("goFonDmtfModes",set_post(array("inband"    =>"inband"    ,"rfc2833"=>"rfc2833" ,"info"   =>"info")));
+        $smarty->assign("goFonAuths",    set_post(array("plaintext" =>"plaintext" ,"md5"    =>"md5"     /*,"rsa"    =>"rsa"*/)));
+        $smarty->assign("goFonTrunks",   set_post(array("yes" =>_("yes") ,"no" => _("no"))));
+
+        /* deativate all fields that are not used by the specified type */
+        foreach($this->attributes as $att){
+            if((!in_array($att,$this->usedattrs[$this->selected_category]))){
+                $smarty->assign($att."USED", "disabled" );
+                $smarty->assign($att, "");
+            }else{
+                $smarty->assign($att."USED", "" );
+                $smarty->assign($att, set_post($this->$att));
+            }
         }
-      }
-    }
-  
-    /* Fill templating stuff */
-    $smarty= get_smarty();
 
+        $smarty->assign("selected_category", set_post($this->selected_category));
 
-    $tmp = $this->plInfo();
-    foreach($tmp['plProvidedAcls'] as $name => $translation){
-      $smarty->assign($name."ACL",$this->getacl($name));
-    }
+        /* Assign attributes */
+        $smarty->assign("base", $this->baseSelector->render());
+        $smarty->assign("goFonDefaultIPs",set_post(array("dynamic"=>_("dynamic"),"network"=>_("Networksettings"))));
 
-    /* Create Arrays for samrty select boxes */
-    $smarty->assign("categories",     array("SIP","IAX","CAPI"));
-    $smarty->assign("goFonTypes",     array("peer"      =>"peer"      ,"user"   =>"user"    ,"friend" =>"friend"));
-    $smarty->assign("goFonDmtfModes", array("inband"    =>"inband"    ,"rfc2833"=>"rfc2833" ,"info"   =>"info"));
-    $smarty->assign("goFonAuths",     array("plaintext" =>"plaintext" ,"md5"    =>"md5"     /*,"rsa"    =>"rsa"*/));
-    $smarty->assign("goFonTrunks",    array("yes" =>_("yes") ,"no" => _("no")));
-
-    /* deativate all fields that are not used by the specified type */
-    foreach($this->attributes as $att){
-      if((!in_array($att,$this->usedattrs[$this->selected_categorie]))){
-        $smarty->assign($att."USED", "disabled" );
-        $smarty->assign($att, "");
-      }else{
-        $smarty->assign($att."USED", "" );
-        $smarty->assign($att, $this->$att);
-      }
-    }
-    
-    $smarty->assign("selected_categorie",$this->selected_categorie);
-
-    /* Assign attributes */
-    $smarty->assign("base", $this->baseSelector->render());
-    $smarty->assign("goFonDefaultIPs",array("dynamic"=>_("dynamic"),"network"=>_("Networksettings")));
- 
-    /* Show main page */
-    $str = $this->netConfigDNS->execute();
-    if(is_object($this->netConfigDNS->dialog)){
-      return($str);
-    }
-    $smarty->assign("netconfig", $str);
-    $smarty->assign("phonesettings", get_template_path("phonesettings.tpl",TRUE,dirname(__FILE__)));
-    return($smarty->fetch (get_template_path('phone.tpl', TRUE,dirname(__FILE__))));
-  }
-
-  function remove_from_parent()
-  {
-    if($this->acl_is_removeable()){
-      $ldap= $this->config->get_ldap_link();
-      $ldap->cd($this->config->current['BASE']);
-
-      $ldap->search ("(&(objectClass=goFonAccount)(goFonHardware=".$this->cn."))", array("uid","cn"));
-      while ($attr =  $ldap->fetch()){
-        msg_dialog::display(_("Error"), sprintf(_("Cannot delete entry because it is still in use by '%s'!"), $attr['cn'][0]), ERROR_DIALOG);
-        return;
-      }
-
-      $this->netConfigDNS->remove_from_parent();
-      $ldap->rmdir($this->dn);
-  
-      new log("remove","phone/".get_class($this),$this->dn,array_keys($this->attrs),$ldap->get_error());
-
-      if (!$ldap->success()){
-        msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
-      }
-      $this->handle_post_events("remove",array("macAddress" => $this->netConfigDNS->macAddress,"ipHostNumber" => $this->netConfigDNS->ipHostNumber));
-
-      /* Delete references to object groups */
-      $ldap->cd ($this->config->current['BASE']);
-      $ldap->search ("(&(objectClass=gosaGroupOfNames)(member=".LDAP::prepare4filter($this->dn)."))", array("cn"));
-      while ($ldap->fetch()){
-        $og= new ogroup($this->config, $ldap->getDN());
-        unset($og->member[$this->dn]);
-        $og->save ();
-      }
+        /* Show main page */
+        $str = $this->netConfigDNS->execute();
+        if(is_object($this->netConfigDNS->dialog)){
+            return($str);
+        }
+        $smarty->assign("netconfig", $str);
+        $smarty->assign("phonesettings", get_template_path("phonesettings.tpl",TRUE,dirname(__FILE__)));
+        return($smarty->fetch (get_template_path('phone.tpl', TRUE,dirname(__FILE__))));
     }
-  }
-
-
-  /* Save data to object */
-  function save_object()
-  {
-    /* Create a base backup and reset the
-       base directly after calling plugin::save_object();
-       Base will be set seperatly a few lines below */
-    $base_tmp = $this->base;
-    plugin::save_object();
-    $this->base = $base_tmp;
-
-    $this->netConfigDNS->save_object();
-
-    /* Refresh base */
-    if ($this->acl_is_moveable($this->base)){
-      if (!$this->baseSelector->update()) {
-        msg_dialog::display(_("Error"), msgPool::permMove(), ERROR_DIALOG);
-      }
-      if ($this->base != $this->baseSelector->getBase()) {
-        $this->base= $this->baseSelector->getBase();
-        $this->is_modified= TRUE;
-      }
+
+    function remove_from_parent()
+    {
+        if($this->acl_is_removeable()){
+            $ldap= $this->config->get_ldap_link();
+            $ldap->cd($this->config->current['BASE']);
+
+            $ldap->search ("(&(objectClass=goFonAccount)(goFonHardware=".$this->cn."))", array("uid","cn"));
+            while ($attr =  $ldap->fetch()){
+                msg_dialog::display(_("Error"), sprintf(_("Cannot delete entry because it is still in use by '%s'!"), $attr['cn'][0]), ERROR_DIALOG);
+                return;
+            }
+
+            $this->netConfigDNS->remove_from_parent();
+            $ldap->rmdir($this->dn);
+
+            new log("remove","phone/".get_class($this),$this->dn,array_keys($this->attrs),$ldap->get_error());
+
+            if (!$ldap->success()){
+                msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
+            }
+            $this->handle_post_events("remove",array("macAddress" => $this->netConfigDNS->macAddress,"ipHostNumber" => $this->netConfigDNS->ipHostNumber));
+
+            /* Delete references to object groups */
+            $ldap->cd ($this->config->current['BASE']);
+            $ldap->search ("(&(objectClass=gosaGroupOfNames)(member=".LDAP::prepare4filter($this->dn)."))", array("cn"));
+            while ($ldap->fetch()){
+                $og= new ogroup($this->config, $ldap->getDN());
+                unset($og->member[$this->dn]);
+                $og->save ();
+            }
+        }
     }
 
-  }
 
+    /* Save data to object */
+    function save_object()
+    {
+        /* Create a base backup and reset the
+           base directly after calling plugin::save_object();
+           Base will be set seperatly a few lines below */
+        $base_tmp = $this->base;
+        plugin::save_object();
+        $this->base = $base_tmp;
 
-  /* Check supplied data */
-  function check()
-  {
-    /* Call common method to give check the hook */
-    $message= plugin::check();
-    $message= array_merge($message, $this->netConfigDNS->check());
+        $this->netConfigDNS->save_object();
 
-    $this->dn= "cn=".$this->cn.",".get_ou("phoneGeneric", "phoneRDN").$this->base;
+        if(isset($_POST['selected_category']) && $this->acl_is_writeable('category')){
+            $this->selected_category=get_post('selected_category');
+        }
 
-    /* To check for valid ip*/
-    if($this->netConfigDNS->ipHostNumber == ""){
-       $message[]=  msgPool::required(_("IP address"));
-    } else {
-      if (!tests::is_ip($this->netConfigDNS->ipHostNumber)){
-        $message[]= msgPool::invalid(_("IP address"));
-      }
-    }
+        /* Refresh base */
+        if ($this->acl_is_moveable($this->base)){
+            if (!$this->baseSelector->update()) {
+                msg_dialog::display(_("Error"), msgPool::permMove(), ERROR_DIALOG);
+            }
+            if ($this->base != $this->baseSelector->getBase()) {
+                $this->base= $this->baseSelector->getBase();
+                $this->is_modified= TRUE;
+            }
+        }
 
-    // Check if a wrong base was supplied
-    if(!$this->baseSelector->checkLastBaseUpdate()){
-      $message[]= msgPool::check_base();;
     }
 
-    /* Check if given name is a valid host/dns name */
-    if(!tests::is_dns_name($this->cn) ){
-      $message[] = msgPool::invalid(_("Name"));
-    }
 
-    if ($this->cn == ""){
-      $message[]= msgPool::required(_("Name"));
-    }
-    if ($this->cn == "0"){ 
-      $message[]= msgPool::reserved(_("Name"));
-    }
+    /* Check supplied data */
+    function check()
+    {
+        /* Call common method to give check the hook */
+        $message= plugin::check();
+        $message= array_merge($message, $this->netConfigDNS->check());
+
+        $this->dn= "cn=".$this->cn.",".get_ou("phoneGeneric", "phoneRDN").$this->base;
 
-    if ($this->orig_dn != $this->dn){
-      $ldap= $this->config->get_ldap_link();
-      $ldap->cd ($this->base);
-      $ldap->search ("(cn=".$this->cn.")", array("cn"));
-      if ($ldap->count() != 0){
-        while ($attrs= $ldap->fetch()){
-
-          if(preg_match("/cn=dhcp,/",$attrs['dn'])){
-            continue;
-          }
-  
-          if ($attrs['dn'] != $this->orig_dn){
-            $message[]= msgPool::duplicated(_("Name"));
-            break;
-          }
+        /* To check for valid ip*/
+        if($this->netConfigDNS->ipHostNumber == ""){
+            $message[]=  msgPool::required(_("IP address"));
+        } else {
+            if (!tests::is_ip($this->netConfigDNS->ipHostNumber)){
+                $message[]= msgPool::invalid(_("IP address"));
+            }
         }
-      }
-    }
 
-    /* Check if we are allowed to create or move this object
-     */
-    if($this->orig_dn == "new" && !$this->acl_is_createable($this->base)){
-      $message[] = msgPool::permCreate();
-    }elseif($this->orig_dn != "new" && $this->base != $this->orig_base && !$this->acl_is_moveable($this->base)){
-      $message[] = msgPool::permMove();
-    }
+        // Check if a wrong base was supplied
+        if(!$this->baseSelector->checkLastBaseUpdate()){
+            $message[]= msgPool::check_base();;
+        }
 
-    return ($message);
-  }
-
-
-  /* Save to LDAP */
-  function save()
-  {
-    plugin::save();
-   
-   
-    /* only to define which attrs to save*/ 
-    $mode = $this->selected_categorie;
-
-    /* Remove all unwanted attrs */
-    foreach($this->attributes as $att){
-      
-      /* Check all attributes, if they are needed for this type of phone */
-      if(!in_array($att,$this->usedattrs[$mode])){
-        $this->attrs[$att] = array();
-      }
-    }
+        /* Check if given name is a valid host/dns name */
+        if(!tests::is_dns_name($this->cn) ){
+            $message[] = msgPool::invalid(_("Name"));
+        }
 
-    /* unset the categorie*/
-    unset($this->attrs['selected_categorie']);
-    
-    /* Remove all empty values */
-    if ($this->orig_dn == 'new'){
-      $attrs= array();
-      foreach ($this->attrs as $key => $val){
-        if (is_array($val) && count($val) == 0){
-          continue;
+        if ($this->cn == ""){
+            $message[]= msgPool::required(_("Name"));
+        }
+        if ($this->cn == "0"){ 
+            $message[]= msgPool::reserved(_("Name"));
         }
-        $attrs[$key]= $val;
-      }
-      $this->attrs= $attrs;
-    }
 
-    if($this->goFonDefaultIP!="dynamic"){
-      $this->attrs['goFonDefaultIP'] = $this->netConfigDNS->ipHostNumber;
-    }    
-
-    $this->attrs = $this->netConfigDNS->getVarsForSaving($this->attrs);
-
-    /* Write back to ldap */
-    $ldap= $this->config->get_ldap_link();
-    if ($this->orig_dn == 'new'){
-      $ldap->cd($this->config->current['BASE']);
-      $ldap->create_missing_trees(preg_replace('/^[^,]+,/', '', $this->dn));
-      $ldap->cd($this->dn);
-      $ldap->add($this->attrs);
-      if (!$ldap->success()){
-        msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
-      }
-      new log("create","phone/".get_class($this),$this->dn,array_keys($this->attrs),$ldap->get_error());
-      $this->handle_post_events("add",array("macAddress" => $this->netConfigDNS->macAddress,"ipHostNumber" => $this->netConfigDNS->ipHostNumber));
-    } else {
-      if ($this->orig_dn != $this->dn){
-        $this->move($this->orig_dn, $this->dn);
-      }
-
-      $ldap->cd($this->dn);
-      $this->cleanup();
-      $ldap->modify ($this->attrs); 
-      new log("modify","phone/".get_class($this),$this->dn,array_keys($this->attrs),$ldap->get_error());
-      if (!$ldap->success()){
-        msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
-      }
-
-      // $user_phone_reload   
-      $ldap->cd ($this->config->current['BASE']); 
-      $user_phone_assignment = $ldap->fetch($ldap->search("(&(objectClass=goFonAccount)(goFonHardware=".$this->cn."))",array("uid")));
-      if($user_phone_assignment){
-        $usertab= new usertabs($this->config,$this->config->data['TABS']['USERTABS'], $user_phone_assignment['dn']);
-        $usertab->by_object['phoneAccount']->is_modified = true;
-        $usertab->save();
-        unset($usertab);
-      }
-      $this->handle_post_events("modify",array("macAddress" => $this->netConfigDNS->macAddress,"ipHostNumber" => $this->netConfigDNS->ipHostNumber));
+        if ($this->orig_dn != $this->dn){
+            $ldap= $this->config->get_ldap_link();
+            $ldap->cd ($this->base);
+            $ldap->search ("(cn=".$this->cn.")", array("cn"));
+            if ($ldap->count() != 0){
+                while ($attrs= $ldap->fetch()){
+
+                    if(preg_match("/cn=dhcp,/",$attrs['dn'])){
+                        continue;
+                    }
+
+                    if ($attrs['dn'] != $this->orig_dn){
+                        $message[]= msgPool::duplicated(_("Name"));
+                        break;
+                    }
+                }
+            }
+        }
+
+        /* Check if we are allowed to create or move this object
+         */
+        if($this->orig_dn == "new" && !$this->acl_is_createable($this->base)){
+            $message[] = msgPool::permCreate();
+        }elseif($this->orig_dn != "new" && $this->base != $this->orig_base && !$this->acl_is_moveable($this->base)){
+            $message[] = msgPool::permMove();
+        }
+
+        return ($message);
     }
-    $this->netConfigDNS->cn = $this->cn;    
-    $this->netConfigDNS->save();
-    if (!$ldap->success()){
-      msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
+
+
+    /* Save to LDAP */
+    function save()
+    {
+        plugin::save();
+
+
+        /* only to define which attrs to save*/ 
+        $mode = $this->selected_category;
+
+        /* Remove all unwanted attrs */
+        foreach($this->attributes as $att){
+
+            /* Check all attributes, if they are needed for this type of phone */
+            if(!in_array($att,$this->usedattrs[$mode])){
+                $this->attrs[$att] = array();
+            }
+        }
+
+        /* unset the category*/
+        unset($this->attrs['selected_category']);
+
+        /* Remove all empty values */
+        if ($this->orig_dn == 'new'){
+            $attrs= array();
+            foreach ($this->attrs as $key => $val){
+                if (is_array($val) && count($val) == 0){
+                    continue;
+                }
+                $attrs[$key]= $val;
+            }
+            $this->attrs= $attrs;
+        }
+
+        if($this->goFonDefaultIP!="dynamic"){
+            $this->attrs['goFonDefaultIP'] = $this->netConfigDNS->ipHostNumber;
+        }    
+
+        $this->attrs = $this->netConfigDNS->getVarsForSaving($this->attrs);
+
+        /* Write back to ldap */
+        $ldap= $this->config->get_ldap_link();
+        if ($this->orig_dn == 'new'){
+            $ldap->cd($this->config->current['BASE']);
+            $ldap->create_missing_trees(preg_replace('/^[^,]+,/', '', $this->dn));
+            $ldap->cd($this->dn);
+            $ldap->add($this->attrs);
+            if (!$ldap->success()){
+                msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
+            }
+            new log("create","phone/".get_class($this),$this->dn,array_keys($this->attrs),$ldap->get_error());
+            $this->handle_post_events("add",array("macAddress" => $this->netConfigDNS->macAddress,"ipHostNumber" => $this->netConfigDNS->ipHostNumber));
+        } else {
+            if ($this->orig_dn != $this->dn){
+                $this->move($this->orig_dn, $this->dn);
+            }
+
+            $ldap->cd($this->dn);
+            $this->cleanup();
+            $ldap->modify ($this->attrs); 
+            new log("modify","phone/".get_class($this),$this->dn,array_keys($this->attrs),$ldap->get_error());
+            if (!$ldap->success()){
+                msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
+            }
+
+            // $user_phone_reload   
+            $ldap->cd ($this->config->current['BASE']); 
+            $user_phone_assignment = $ldap->fetch($ldap->search("(&(objectClass=goFonAccount)(goFonHardware=".$this->cn."))",array("uid")));
+            if($user_phone_assignment){
+                $usertab= new usertabs($this->config,$this->config->data['TABS']['USERTABS'], $user_phone_assignment['dn']);
+                $usertab->by_object['phoneAccount']->is_modified = true;
+                $usertab->save();
+                unset($usertab);
+            }
+            $this->handle_post_events("modify",array("macAddress" => $this->netConfigDNS->macAddress,"ipHostNumber" => $this->netConfigDNS->ipHostNumber));
+        }
+        $this->netConfigDNS->cn = $this->cn;    
+        $this->netConfigDNS->save();
+        if (!$ldap->success()){
+            msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
+        }
     }
-  }
-
-
-  /* Display generic part for server copy & paste */
-  function getCopyDialog()
-  {
-    $vars = array("cn");
-    $smarty = get_smarty();
-    $smarty->assign("cn" ,$this->cn);
-    $smarty->assign("object","phone");
-    $str = $smarty->fetch(get_template_path("paste_generic.tpl",TRUE,dirname(__FILE__)));
-    $ret = array();
-    $ret['string'] = $str;
-    $ret['status'] = "";
-    return($ret);
-  }
-
-
-  function saveCopyDialog()
-  {
-    if(isset($_POST['cn'])){
-      $this->cn = $_POST['cn'];
+
+
+    /* Display generic part for server copy & paste */
+    function getCopyDialog()
+    {
+        $vars = array("cn");
+        $smarty = get_smarty();
+        $smarty->assign("cn" ,set_post($this->cn));
+        $smarty->assign("object","phone");
+        $str = $smarty->fetch(get_template_path("paste_generic.tpl",TRUE,dirname(__FILE__)));
+        $ret = array();
+        $ret['string'] = $str;
+        $ret['status'] = "";
+        return($ret);
     }
-  }
 
 
-  function PrepareForCopyPaste($source)
-  {
-    plugin::PrepareForCopyPaste($source);
-    if(isset($source['macAddress'][0])){
-      $this->netConfigDNS->macAddress = $source['macAddress'][0];
+    function saveCopyDialog()
+    {
+        if(isset($_POST['cn'])){
+            $this->cn = get_post('cn');
+        }
     }
-    if(isset($source['ipHostNumber'][0])){
-      $this->netConfigDNS->ipHostNumber = $source['ipHostNumber'][0];
+
+
+    function PrepareForCopyPaste($source)
+    {
+        plugin::PrepareForCopyPaste($source);
+        if(isset($source['macAddress'][0])){
+            $this->netConfigDNS->macAddress = $source['macAddress'][0];
+        }
+        if(isset($source['ipHostNumber'][0])){
+            $this->netConfigDNS->ipHostNumber = $source['ipHostNumber'][0];
+        }
+
+        $source_o = new phoneGeneric($this->config, $source['dn']);
+        $this->selected_category = $source_o->selected_category;
     }
 
-    $source_o = new phoneGeneric($this->config, $source['dn']);
-    $this->selected_categorie = $source_o->selected_categorie;
-  }
-
-
-  /* Return plugin informations for acl handling
-      #FIXME FAIscript seams to ununsed within this class... */
-  static function plInfo()
-  {
-    return (array(
-          "plShortName"   => _("Generic"),
-          "plDescription" => _("Phone generic"),
-          "plSelfModify"  => FALSE,
-          "plDepends"     => array(),
-          "plPriority"    => 0,
-          "plSection"     => array("administration"),
-          "plRequirements"=> array(
-              'ldapSchema' => array('goFonHardware' => '>=2.7'),
-              'onFailureDisablePlugin' => array(get_class())
-              ),
-          "plCategory"    => array("phone" => array("description"  => _("Phone hardware"),
-                  "objectClass"  => "goFonHardware")),
-          "plProperties" =>
-          array(
-              array(
-                  "name"          => "phoneRDN",
-                  "type"          => "rdn",
-                  "default"       => "ou=phones,ou=systems,",
-                  "description"   => _("The 'phoneRDN' statement defines the location where new phones will be created. The default is 'ou=phones,ou=systems,'."),
-                  "check"         => "gosaProperty::isRdn",
-                  "migrate"       => "migrate_phoneRDN",
-                  "group"         => "plugin",
-                  "mandatory"     => FALSE
-                  )
-              ),
-
-          "plProvidedAcls"=> array(
-            "cn"                  => _("Name"),
-            "base"                => _("Base"),
-            "description"         => _("Description"),
-            "goFonType"           => _("SIP Mode"),
-            "goFonDmtfMode"       => _("SIP DTMF mode"),
-            "goFonDefaultIP"      => _("SIP Default ip"),
-            "goFonQualify"        => _("SIP Qualify"),
-            "goFonAuth"           => _("IAX authentication type"),
-            "goFonSecret"         => _("IAX secret"),
-            "goFonAccountCode"    => _("IAX account code"),
-            "goFonTrunk"          => _("IAX trunk lines"),
-            "goFonPermit"         => _("IAX permit settings"),
-            "goFonDeny"           => _("IAX deny settings"),
-            "goFonMSN"            => _("CAPI MSN"),
-            "categorie"  => _("Hardware type"))
-          ));
-  }
+
+    /* Return plugin informations for acl handling
+#FIXME FAIscript seams to ununsed within this class... */
+    static function plInfo()
+    {
+        return (array(
+                    "plShortName"   => _("Generic"),
+                    "plDescription" => _("Phone generic"),
+                    "plSelfModify"  => FALSE,
+                    "plDepends"     => array(),
+                    "plPriority"    => 0,
+                    "plSection"     => array("administration"),
+                    "plRequirements"=> array(
+                        'ldapSchema' => array('goFonHardware' => '>=2.7'),
+                        'onFailureDisablePlugin' => array(get_class())
+                        ),
+                    "plCategory"    => array("phone" => array("description"  => _("Phone hardware"),
+                            "objectClass"  => "goFonHardware")),
+                    "plProperties" =>
+                    array(
+                        array(
+                            "name"          => "phoneRDN",
+                            "type"          => "rdn",
+                            "default"       => "ou=phones,ou=systems,",
+                            "description"   => _("The 'phoneRDN' statement defines the location where new phones will be created. The default is 'ou=phones,ou=systems,'."),
+                            "check"         => "gosaProperty::isRdn",
+                            "migrate"       => "migrate_phoneRDN",
+                            "group"         => "plugin",
+                            "mandatory"     => FALSE
+                            )
+                        ),
+
+            "plProvidedAcls"=> array(
+                    "cn"                  => _("Name"),
+                    "base"                => _("Base"),
+                    "description"         => _("Description"),
+                    "goFonType"           => _("SIP Mode"),
+                    "goFonDmtfMode"       => _("SIP DTMF mode"),
+                    "goFonDefaultIP"      => _("SIP Default ip"),
+                    "goFonQualify"        => _("SIP Qualify"),
+                    "goFonAuth"           => _("IAX authentication type"),
+                    "goFonSecret"         => _("IAX secret"),
+                    "goFonAccountCode"    => _("IAX account code"),
+                    "goFonTrunk"          => _("IAX trunk lines"),
+                    "goFonPermit"         => _("IAX permit settings"),
+                    "goFonDeny"           => _("IAX deny settings"),
+                    "goFonMSN"            => _("CAPI MSN"),
+                    "category"  => _("Hardware type"))
+                ));
+    }
 
 
 }