Check the value returned by fopen() during display initialization

12:12 < kahmalo> Opening /dev/tty may fail; what does newterm do then?
20:15 < Miciah> fonseca: You always gotta check the return value of fopen. Silly head.

diff --git a/tig.c b/tig.c
index 8bae0d5b7e1f897a6db4b4566b20247e9cf3e7b4..6a1f3d1280a894fc8afabd22d0a96f694c587824 100644 (file)
--- a/tig.c
+++ b/tig.c
@@ -2583,6 +2583,8 @@ init_display(void)
                /* Leave stdin and stdout alone when acting as a pager. */
                FILE *io = fopen("/dev/tty", "r+");
 
+               if (!io)
+                       die("Failed to open /dev/tty");
                cursed = !!newterm(NULL, io, io);
        }