Code

[PATCH] fix null TZ problems on os/x
authorBrad Roberts <braddr@puremagic.com>
Sat, 13 Aug 2005 10:22:46 +0000 (03:22 -0700)
committerJunio C Hamano <junkio@cox.net>
Sun, 14 Aug 2005 01:28:54 +0000 (18:28 -0700)
It seems that the localtime() libc routine doesn't care for finding a TZ
that's empty.  It's ok with TZ not being set.  Setting the TZ to GMT allowed
these tests to pass.

$ uname -v
Darwin Kernel Version 7.9.0: Wed Mar 30 20:11:17 PST 2005; root:xnu/xnu-517.12.7.obj~1/RELEASE_PPC

Signed-off-by: Brad Roberts <braddr@puremagic.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
t/t1100-commit-tree-options.sh
t/t5000-tar-tree.sh

index e59f724f2a72f9c9a9237ff477d472811362ce0b..19a0ed4d20409a79c5615004ceb63a969f0414de 100755 (executable)
@@ -32,7 +32,7 @@ test_expect_success \
      GIT_COMMITTER_NAME="Committer Name" \
      GIT_COMMITTER_EMAIL="committer@email" \
      GIT_COMMITTER_DATE="2005-05-26 23:30" \
-     TZ= git-commit-tree `cat treeid` >commitid 2>/dev/null'
+     TZ=GMT git-commit-tree `cat treeid` >commitid 2>/dev/null'
 
 test_expect_success \
     'read commit' \
index 6d72ed34c10f734bc0f22a0155d789130548bc6d..abce66921c0d7a478271ece31329bb52b579b159 100755 (executable)
@@ -41,7 +41,7 @@ test_expect_success \
      find a -type l | xargs git-update-cache --add &&
      treeid=`git-write-tree` &&
      echo $treeid >treeid &&
-     TZ= GIT_COMMITTER_DATE="2005-05-27 22:00:00" \
+     TZ=GMT GIT_COMMITTER_DATE="2005-05-27 22:00:00" \
      git-commit-tree $treeid </dev/null >.git/HEAD'
 
 test_expect_success \
@@ -50,7 +50,7 @@ test_expect_success \
 
 test_expect_success \
     'validate file modification time' \
-    'TZ= tar tvf b.tar a/a |
+    'TZ=GMT tar tvf b.tar a/a |
      awk \{print\ \$4,\ \(length\(\$5\)\<7\)\ ?\ \$5\":00\"\ :\ \$5\} \
      >b.mtime &&
      echo "2005-05-27 22:00:00" >expected.mtime &&