Git.pm: Avoid ppport.h

This makes us not include ppport.h which seems not to give us anything
real anyway; it is useful for checking for portability warts but since
Devel::PPPort is a portability wart itself, we shouldn't require it
for build. You can check for portability problems by calling make check
in perl/.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/perl/Git.xs b/perl/Git.xs
index cb232618c8f4d87fd9dc177afff9c34af6ee3bdd..51bfac3bd52e0c76afc813ec88caafce3898c90d 100644 (file)
--- a/perl/Git.xs
+++ b/perl/Git.xs
@@ -15,8 +15,6 @@
 #include "perl.h"
 #include "XSUB.h"
 
-#include "ppport.h"
-
 #undef die
 
 

diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 25ae54a5151143ceb8ed1710b034b8d072d8e91f..97ee9af9c9834d759c33b17bca7b66eaef200e4f 100644 (file)
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -5,6 +5,11 @@ sub MY::postamble {
 instlibdir:
        @echo '$(INSTALLSITEARCH)'
 
+check:
+       perl -MDevel::PPPort -le 'Devel::PPPort::WriteFile(".ppport.h")' && \
+       perl .ppport.h --compat-version=5.6.0 Git.xs && \
+       rm .ppport.h
+
 MAKE_FRAG
 }
 
@@ -24,8 +29,3 @@ WriteMakefile(
        MYEXTLIB        => '../libgit.a',
        INC             => '-I. -I..',
 );
-
-
-use Devel::PPPort;
-
--s 'ppport.h' or Devel::PPPort::WriteFile();