Code

Trivial path quoting fixes in git-instaweb
authorSean Estabrooks <seanlkml@sympatico.ca>
Sat, 18 Jul 2009 16:45:44 +0000 (09:45 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sun, 26 Jul 2009 18:27:27 +0000 (11:27 -0700)
Bodo Schlecht noticed that Instaweb didn't propely quote all
path instances in the Apache config file it generated.

Acked-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-instaweb.sh

index 5f4419b69b58769e8fee7a60109520a095a831c5..32f6496b0d36cff061f00a4ad70b6fa4d34c2646 100755 (executable)
@@ -256,7 +256,7 @@ apache2_conf () {
        mkdir -p "$GIT_DIR/gitweb/logs"
        bind=
        test x"$local" = xtrue && bind='127.0.0.1:'
-       echo 'text/css css' > $fqgitdir/mime.types
+       echo 'text/css css' > "$fqgitdir/mime.types"
        cat > "$conf" <<EOF
 ServerName "git-instaweb"
 ServerRoot "$fqgitdir/gitweb"
@@ -272,7 +272,7 @@ EOF
                fi
        done
        cat >> "$conf" <<EOF
-TypesConfig $fqgitdir/mime.types
+TypesConfig "$fqgitdir/mime.types"
 DirectoryIndex gitweb.cgi
 EOF