the call to rrd_flush has appeared when rrd_open was fleshed out. It used to be an...

which is something entirely different than the current rrd_flush implementation with fdatasync was ...

we can safely drop this and gain performance for holt winters in the process ... -- tobi

git-svn-id: svn://svn.oetiker.ch/rrdtool/trunk/program@1760 a5681a0c-68f1-0310-ab6d-d61299d08faa

diff --git a/src/rrd_hw.c b/src/rrd_hw.c
index 6f2c50732051c5c16dfbb8644904b968e8c40956..e6b23dbe189160b6743f11416e759d5939c1ca44 100644 (file)
--- a/src/rrd_hw.c
+++ b/src/rrd_hw.c
@@ -166,7 +166,7 @@ int apply_smoother(
         free(rrd_values);
         return -1;
     }
-    rrd_flush(rrd_file);
+
     /* could read all data in a single block, but we need to
      * check for NA values */
     for (i = 0; i < row_count; ++i) {

diff --git a/src/rrd_open.c b/src/rrd_open.c
index d2ec549754d62d1a2d4e5b6597884212fb350599..16545145ba214444219fbd09b72e3765ae2d7a8e 100644 (file)
--- a/src/rrd_open.c
+++ b/src/rrd_open.c
@@ -542,7 +542,7 @@ void rrd_dontneed(
 #if defined DEBUG && DEBUG > 1
     mincore_print(rrd_file, "after");
 #endif
-#endif                          /* without madvise and posix_fadvise ist does not make much sense todo anything */
+#endif                          /* without madvise and posix_fadvise it does not make much sense todo anything */
 }
 
 
@@ -685,22 +685,6 @@ ssize_t rrd_write(
 }
 
 
-/* flush all data pending to be written to FD.  */
-
-void rrd_flush(
-    rrd_file_t *rrd_file)
-{
-#ifndef WIN32
-    rrd_simple_file_t *rrd_simple_file;
-    rrd_simple_file = (rrd_simple_file_t *)rrd_file->pvt;
-    if (fdatasync(rrd_simple_file->fd) != 0) {
-        rrd_set_error("flushing fd %d: %s", rrd_simple_file->fd,
-                      rrd_strerror(errno));
-    }
-#endif
-}
-
-
 /* Initialize RRD header.  */
 
 void rrd_init(