Code

gitweb: Don't die_error in git_tag after already printing headers
authorAnders Kaseorg <andersk@MIT.EDU>
Fri, 27 Aug 2010 17:38:16 +0000 (13:38 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 31 Aug 2010 16:52:48 +0000 (09:52 -0700)
This fixes an XML error when visiting a nonexistent tag
(i.e. "../gitweb.cgi?p=git.git;a=tag;h=refs/tags/BADNAME").

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl

index d0687f45814eb72da5d8b59c49d86cced01c8715..a85e2f63197649bff4842ea2970448205618c104 100755 (executable)
@@ -5191,15 +5191,15 @@ sub git_summary {
 }
 
 sub git_tag {
-       my $head = git_get_head_hash($project);
-       git_header_html();
-       git_print_page_nav('','', $head,undef,$head);
        my %tag = parse_tag($hash);
 
        if (! %tag) {
                die_error(404, "Unknown tag object");
        }
 
+       my $head = git_get_head_hash($project);
+       git_header_html();
+       git_print_page_nav('','', $head,undef,$head);
        git_print_header_div('commit', esc_html($tag{'name'}), $hash);
        print "<div class=\"title_text\">\n" .
              "<table class=\"object_header\">\n" .