Fix bug #338838: Using double-click on a selected shape to switch to that shape's...

diff --git a/src/arc-context.cpp b/src/arc-context.cpp
index e33985c2296f4b0992b695cee926ccfc2dc30e4a..83cdd73c1ac382b058482af329d11dcdedc30feb 100644 (file)
--- a/src/arc-context.cpp
+++ b/src/arc-context.cpp
@@ -266,7 +266,7 @@ static gint sp_arc_context_root_handler(SPEventContext *event_context, GdkEvent
             event_context->xp = event_context->yp = 0;
             if (event->button.button == 1 && !event_context->space_panning) {
                 dragging = false;
-                sp_event_context_snap_window_closed(event_context);
+                sp_event_context_snap_window_closed(event_context, false); //button release will also occur on a double-click; in that case suppress warnings
                 if (!event_context->within_tolerance) {
                     // we've been dragging, finish the arc
                     sp_arc_finish(ac);

diff --git a/src/box3d-context.cpp b/src/box3d-context.cpp
index 5fb85d793686ac94940eb5837e07ba1fb8db238a..a28463e0223201c92f076b56f02b6bf38ad5e96a 100644 (file)
--- a/src/box3d-context.cpp
+++ b/src/box3d-context.cpp
@@ -373,7 +373,7 @@ static gint sp_box3d_context_root_handler(SPEventContext *event_context, GdkEven
         event_context->xp = event_context->yp = 0;
         if ( event->button.button == 1  && !event_context->space_panning) {
             dragging = false;
-            sp_event_context_snap_window_closed(event_context);
+            sp_event_context_snap_window_closed(event_context, false); //button release will also occur on a double-click; in that case suppress warnings
 
             if (!event_context->within_tolerance) {
                 // we've been dragging, finish the box

diff --git a/src/rect-context.cpp b/src/rect-context.cpp
index 9c1c704ddac10021da8b40caead1c6a089d7982f..c05f007599df42968f92ea688079d275362dd5d0 100644 (file)
--- a/src/rect-context.cpp
+++ b/src/rect-context.cpp
@@ -306,7 +306,7 @@ static gint sp_rect_context_root_handler(SPEventContext *event_context, GdkEvent
         event_context->xp = event_context->yp = 0;
         if (event->button.button == 1 && !event_context->space_panning) {
             dragging = false;
-            sp_event_context_snap_window_closed(event_context);
+            sp_event_context_snap_window_closed(event_context, false); //button release will also occur on a double-click; in that case suppress warnings
 
             if (!event_context->within_tolerance) {
                 // we've been dragging, finish the rect

diff --git a/src/spiral-context.cpp b/src/spiral-context.cpp
index 67ee82b358abc213709fbc249c65dbb2a87a5bc4..cd90ac1cf15362830cb1e07857100d1a7d213457 100644 (file)
--- a/src/spiral-context.cpp
+++ b/src/spiral-context.cpp
@@ -269,7 +269,7 @@ sp_spiral_context_root_handler(SPEventContext *event_context, GdkEvent *event)
             event_context->xp = event_context->yp = 0;
             if (event->button.button == 1 && !event_context->space_panning) {
                 dragging = FALSE;
-                sp_event_context_snap_window_closed(event_context);
+                sp_event_context_snap_window_closed(event_context, false); //button release will also occur on a double-click; in that case suppress warnings
                 if (!event_context->within_tolerance) {
                     // we've been dragging, finish the spiral
                     sp_spiral_finish(sc);

diff --git a/src/star-context.cpp b/src/star-context.cpp
index 5361219aa7c105fa61249b091306568bc67900cc..a004426081af848b10bcbc15851afa57b04f3b60 100644 (file)
--- a/src/star-context.cpp
+++ b/src/star-context.cpp
@@ -281,7 +281,7 @@ static gint sp_star_context_root_handler(SPEventContext *event_context, GdkEvent
         event_context->xp = event_context->yp = 0;
         if (event->button.button == 1 && !event_context->space_panning) {
             dragging = FALSE;
-            sp_event_context_snap_window_closed(event_context);
+            sp_event_context_snap_window_closed(event_context, false); //button release will also occur on a double-click; in that case suppress warnings
             if (!event_context->within_tolerance) {
                 // we've been dragging, finish the star
                 sp_star_finish (sc);

diff --git a/src/text-context.cpp b/src/text-context.cpp
index a5af083859fc182a7c56d43ffd7bddc64b1f711d..21f74a84b5afcd3c23cacf75da801a1e449cb2f9 100644 (file)
--- a/src/text-context.cpp
+++ b/src/text-context.cpp
@@ -388,7 +388,7 @@ sp_text_context_item_handler(SPEventContext *event_context, SPItem *item, GdkEve
         case GDK_BUTTON_RELEASE:
             if (event->button.button == 1 && tc->dragging && !event_context->space_panning) {
                 tc->dragging = 0;
-                sp_event_context_snap_window_closed(event_context);
+                sp_event_context_snap_window_closed(event_context, false); //button release will also occur on a double-click; in that case suppress warnings
                 ret = TRUE;
             }
             break;