Code

bisect: fix another instance of eval'ed string
authorChristian Couder <chriscool@tuxfamily.org>
Fri, 27 Feb 2009 06:31:22 +0000 (07:31 +0100)
committerJunio C Hamano <gitster@pobox.com>
Fri, 27 Feb 2009 22:30:34 +0000 (14:30 -0800)
When there is nothing to be skipped, the output from
rev-list --bisect-vars was eval'ed without first being
strung together with &&; this is probably not a problem
as it is much less likely to be a bad input than the list
handcrafted by the filter_skip function, but it still is
a good discipline.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-bisect.sh

index f9a5c0bdf4382c09a978ce42b013c507c0fb1e0c..b95dbbbbb243069f5e673869b3867cfa4151aff7 100755 (executable)
@@ -263,7 +263,13 @@ filter_skipped() {
        _skip="$2"
 
        if [ -z "$_skip" ]; then
-               eval_rev_list "$_eval"
+               eval_rev_list "$_eval" | {
+                       while read line
+                       do
+                               echo "$line &&"
+                       done
+                       echo ':'
+               }
                return
        fi