summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 329a304)
raw | patch | inline | side by side (parent: 329a304)
author | Junio C Hamano <junkio@cox.net> | |
Tue, 8 Aug 2006 20:11:16 +0000 (13:11 -0700) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Tue, 8 Aug 2006 20:20:18 +0000 (13:20 -0700) |
When an ancient "git" that does not understand "describe"
command is on the $PATH, "git describe" emitted a Usage message
without exiting non-zero status (which is a mistake we cannot
fix retroactively). Catch this case to make sure we do not try
using phoney multi-line string as a version number.
Signed-off-by: Junio C Hamano <junkio@cox.net>
command is on the $PATH, "git describe" emitted a Usage message
without exiting non-zero status (which is a mistake we cannot
fix retroactively). Catch this case to make sure we do not try
using phoney multi-line string as a version number.
Signed-off-by: Junio C Hamano <junkio@cox.net>
GIT-VERSION-GEN | patch | blob | history |
diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index 1ce217dd7ba020e0aca1caf0008f65ad83eb309e..14923c973bdcb87aaacb27f98eecc6215d5293b6 100755 (executable)
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
GVF=GIT-VERSION-FILE
DEF_VER=v1.4.2.GIT
+LF='
+'
+
# First try git-describe, then see if there is a version file
# (included in release tarballs), then default
-if VN=$(git describe --abbrev=4 HEAD 2>/dev/null); then
+if VN=$(git describe --abbrev=4 HEAD 2>/dev/null) &&
+ case "$VN" in
+ *$LF*) (exit 1) ;;
+ v[0-9]*) : happy ;;
+ esac
+then
VN=$(echo "$VN" | sed -e 's/-/./g');
elif test -f version
then