screen_song: fix memory leak

diff --git a/NEWS b/NEWS
index e913f5ae3d3ccc683a25b009c7b5b08e80a0cfdf..59ca615ad196f29041090b88a2ee91614687a461 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
 ncmpc 0.28 - not yet released
 * fix crash on lyrics screen
+* fix memory leak
 
 ncmpc 0.27 - (2017-03-25)
 * work around connect failure if /var/run/mpd/socket does not exist

diff --git a/src/screen_song.c b/src/screen_song.c
index 61c77d517fc0f5e3bf09fbd81fbbde5b98e0662d..d7b6d2c51d5b4feb7e52be03d6d39f67bb838064 100644 (file)
--- a/src/screen_song.c
+++ b/src/screen_song.c
@@ -213,9 +213,12 @@ screen_song_append(const char *label, const char *value, unsigned label_col)
 
                char *p = g_strdup(value_iter);
                unsigned width = utf8_cut_width(p, value_col);
-               if (width == 0)
+               if (width == 0) {
                        /* not enough room for anything - bail out */
+                       g_free(entry);
+                       g_free(p);
                        break;
+               }
 
                *entry_iter = 0;