summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 77b5be2)
raw | patch | inline | side by side (parent: 77b5be2)
author | Jonathan Nieder <jrnieder@gmail.com> | |
Wed, 21 Jul 2010 00:01:01 +0000 (19:01 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 21 Jul 2010 18:52:26 +0000 (11:52 -0700) |
The correct advice should have been taken from c289c31 (t/t7006: ignore
return status of shell's unset builtin, 2010-06-02). A real-life issue
we experienced was with "unset", not with "export" (exporting an
unset variable may have similar portability issues, though).
Signed-off-by: Junio C Hamano <gitster@pobox.com>
return status of shell's unset builtin, 2010-06-02). A real-life issue
we experienced was with "unset", not with "export" (exporting an
unset variable may have similar portability issues, though).
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/README | patch | blob | history |
diff --git a/t/README b/t/README
index a5901424388b9cfb525b7bdbfd6d5afda3c9e014..0d1183c3e69904e9e3543d757f14f10c629e199b 100644 (file)
--- a/t/README
+++ b/t/README
test ...
That way all of the commands in your tests will succeed or fail. If
- you must ignore the return value of something (e.g. the return
- value of export is unportable) it's best to indicate so explicitly
- with a semicolon:
+ you must ignore the return value of something (e.g., the return
+ after unsetting a variable that was already unset is unportable) it's
+ best to indicate so explicitly with a semicolon:
- export HLAGH;
+ unset HLAGH;
git merge hla &&
git push gh &&
test ...