Code

push: Correctly initialize nonfastforward in transport_push.
authorMatthieu Moy <Matthieu.Moy@imag.fr>
Sun, 20 Sep 2009 17:33:20 +0000 (19:33 +0200)
committerJunio C Hamano <gitster@pobox.com>
Sun, 20 Sep 2009 19:11:29 +0000 (12:11 -0700)
The variable is assigned unconditionally in print_push_status, but
print_push_status is not reached by all codepaths. In particular, this
fixes a bug where "git push ... nonexisting-branch" was complaining about
non-fast forward.

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
transport.c

index f231b355f24476372c9b89c35a41231a18e45719..ce1d25e46ec59568b4e5751ae61ac145043625d7 100644 (file)
@@ -1001,8 +1001,9 @@ int transport_set_option(struct transport *transport,
 
 int transport_push(struct transport *transport,
                   int refspec_nr, const char **refspec, int flags,
-                  int * nonfastforward)
+                  int *nonfastforward)
 {
+       *nonfastforward = 0;
        verify_remote_names(refspec_nr, refspec);
 
        if (transport->push)