summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 057e713)
raw | patch | inline | side by side (parent: 057e713)
author | Junio C Hamano <gitster@pobox.com> | |
Wed, 11 Feb 2009 01:42:04 +0000 (17:42 -0800) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 11 Feb 2009 06:26:37 +0000 (22:26 -0800) |
The worst offenders are "continue;;" and "break;;" in switch statements.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
fast-import.c | patch | blob | history | |
rerere.c | patch | blob | history | |
tree.c | patch | blob | history | |
walker.c | patch | blob | history |
diff --git a/fast-import.c b/fast-import.c
index 03b13e0621e100b1c52a0384fbfe81aede9beb16..3ef3413e69896d45012ea94b3678959d5d2cceb0 100644 (file)
--- a/fast-import.c
+++ b/fast-import.c
/* Generate the fan-out array. */
c = idx;
for (i = 0; i < 256; i++) {
- struct object_entry **next = c;;
+ struct object_entry **next = c;
while (next < last) {
if ((*next)->sha1[0] != i)
break;
diff --git a/rerere.c b/rerere.c
index 718fb526dd1fbbc5de18784586d37d6069807b77..3518207c178904b91ce28f8d3bf2ba0ee560d0e7 100644 (file)
--- a/rerere.c
+++ b/rerere.c
hex = xstrdup(sha1_to_hex(sha1));
string_list_insert(path, rr)->util = hex;
if (mkdir(git_path("rr-cache/%s", hex), 0755))
- continue;;
+ continue;
handle_file(path, NULL, rr_path(hex, "preimage"));
fprintf(stderr, "Recorded preimage for '%s'\n", path);
}
index dfe4d5f303bdecd5d446db1044251f77eae03a3d..25d2e29fa8b1dfb964b97a10898c77d8fe86ef78 100644 (file)
--- a/tree.c
+++ b/tree.c
case 0:
continue;
case READ_TREE_RECURSIVE:
- break;;
+ break;
default:
return -1;
}
diff --git a/walker.c b/walker.c
index 679adab6a0fccef460acaf90b116b8c6cb9bd460..e57630e983488e5c0222dc47a5e32d6efb184762 100644 (file)
--- a/walker.c
+++ b/walker.c
static void report_missing(const struct object *obj)
{
char missing_hex[41];
- strcpy(missing_hex, sha1_to_hex(obj->sha1));;
+ strcpy(missing_hex, sha1_to_hex(obj->sha1));
fprintf(stderr, "Cannot obtain needed %s %s\n",
obj->type ? typename(obj->type): "object", missing_hex);
if (!is_null_sha1(current_commit_sha1))