Code

Document pre-condition for tree_entry_interesting
authorElijah Newren <newren@gmail.com>
Thu, 26 Aug 2010 06:21:46 +0000 (00:21 -0600)
committerJunio C Hamano <gitster@pobox.com>
Thu, 26 Aug 2010 16:53:35 +0000 (09:53 -0700)
tree_entry_interesting will fail to find appropriate matches if the base
directory path is not terminated with a slash.  Knowing this earlier would
have saved me some debugging time.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
tree-diff.c

index fe9f52c4796512f40869e511b55a2d97fa84532e..4d85fef5d0aebbf5867cd95009721f0e28d71523 100644 (file)
@@ -85,6 +85,8 @@ static int compare_tree_entry(struct tree_desc *t1, struct tree_desc *t2, const
 /*
  * Is a tree entry interesting given the pathspec we have?
  *
+ * Pre-condition: baselen == 0 || base[baselen-1] == '/'
+ *
  * Return:
  *  - 2 for "yes, and all subsequent entries will be"
  *  - 1 for yes