summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 6520245)
raw | patch | inline | side by side (parent: 6520245)
author | Krzysztof Kosiński <tweenk.pl@gmail.com> | |
Wed, 23 Dec 2009 19:51:48 +0000 (20:51 +0100) | ||
committer | Krzysztof Kosiński <tweenk.pl@gmail.com> | |
Wed, 23 Dec 2009 19:51:48 +0000 (20:51 +0100) |
src/desktop.cpp | patch | blob | history | |
src/ui/tool/path-manipulator.cpp | patch | blob | history | |
src/ui/tool/shape-record.h | patch | blob | history |
diff --git a/src/desktop.cpp b/src/desktop.cpp
index b1b9a29558733ebb207aab2f691af3950814d2f5..e4e2ed7bca30aad8709f76430860e4abc03a6f3e 100644 (file)
--- a/src/desktop.cpp
+++ b/src/desktop.cpp
#include "widgets/desktop-widget.h"
#include "box3d-context.h"
-// TODO those includes are only for the braindead quick zoom implementation.
-// Remove them after fixing this.
+// TODO those includes are only for node tool quick zoom. Remove them after fixing it.
#include "ui/tool/node-tool.h"
#include "ui/tool/control-point-selection.h"
_quick_zoom_stored_area = get_display_area();
bool zoomed = false;
- // TODO This is brain damage. This needs to migrate into the node tool,
- // but currently the design of this method is sufficiently broken
- // to prevent this.
+ // TODO This needs to migrate into the node tool, but currently the design
+ // of this method is sufficiently wrong to prevent this.
if (!zoomed && INK_IS_NODE_TOOL(event_context)) {
InkNodeTool *nt = static_cast<InkNodeTool*>(event_context);
if (!nt->_selected_nodes->empty()) {
index 0ad509a9b473ab06586834a3245c968dd3a967e1..f247e553789d2378999e35d0b31534a96148189a 100644 (file)
if (empty()) return;
if (!_lpe_key.empty()) {
- // LPE brain damage follows - copied from nodepath.cpp
+ // copied from nodepath.cpp
// NOTE: if we are editing an LPE param, _path is not actually an SPPath, it is
- // a LivePathEffectObject.
+ // a LivePathEffectObject. (mad laughter)
Effect *lpe = LIVEPATHEFFECT(_path)->get_lpe();
if (lpe) {
PathParam *pathparam = dynamic_cast<PathParam *>(lpe->getParameter(_lpe_key.data()));
}
}
-/** LPE brain damage */
+/** Figure out in what attribute to store the nodetype string. */
Glib::ustring PathManipulator::_nodetypesKey()
{
if (_lpe_key.empty()) return "sodipodi:nodetypes";
return _lpe_key + "-nodetypes";
}
-/** LPE brain damage */
+/** Return the XML node we are editing.
+ * This method is wrong but necessary at the moment. */
Inkscape::XML::Node *PathManipulator::_getXMLNode()
{
if (_lpe_key.empty()) return _path->repr;
index 96c1551f6473b99476f4f9ae78750a58beef67b6..fdb49ac36a66024ecb17a717ba2bcd95cb16d3e0 100644 (file)
SPItem *item; // SP node for the edited shape
Geom::Matrix edit_transform; // how to transform controls - used for clipping paths and masks
ShapeRole role;
- Glib::ustring lpe_key; // This is LPE brain damage that I do not want to speak of
+ Glib::ustring lpe_key; // name of LPE shape param being edited
inline bool operator==(ShapeRecord const &o) const { return item == o.item; }
inline bool operator<(ShapeRecord const &o) const { return item < o.item; }