Code

Explicitly set X to avoid potential build breakage
authorMichael Palimaka <kensington@astralcloak.net>
Wed, 8 Feb 2012 10:59:04 +0000 (21:59 +1100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 9 Feb 2012 22:31:48 +0000 (14:31 -0800)
$X is appended to binary names for Windows builds (ie. git.exe).
Pollution from the environment can inadvertently trigger this behaviour,
resulting in 'git' turning into 'gitwhatever' without warning.

Signed-off-by: Michael Palimaka <kensington@astralcloak.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Makefile

index b21d2f14176d08011cea79790eb2246d50787ec9..6e70a6d44c7a9e0070f702987e796c71e4325690 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -428,6 +428,9 @@ PROGRAM_OBJS += upload-pack.o
 PROGRAM_OBJS += http-backend.o
 PROGRAM_OBJS += sh-i18n--envsubst.o
 
+# Binary suffix, set to .exe for Windows builds
+X =
+
 PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))
 
 TEST_PROGRAMS_NEED_X += test-chmtime