Code

sensors plugin: Fix the return status of `sensors_snprintf_chip_name'.
authorFlorian Forster <octo@verplant.org>
Fri, 18 Apr 2008 05:23:48 +0000 (07:23 +0200)
committerFlorian Forster <octo@verplant.org>
Fri, 18 Apr 2008 05:23:48 +0000 (07:23 +0200)
The function should return <0 only if an error occured, but in two out of three
branches the initial status of -1 was not modified. This may have rendered the
sensors plugin unusable for some people.

src/sensors.c

index 2a0a9ea5788b05890ec59478cbea8ab67ee4aaa5..173ed9c14553e160f3a5ac183ab36d372d1b7f80 100644 (file)
@@ -189,14 +189,14 @@ static int sensors_snprintf_chip_name (char *buf, size_t buf_size,
        }
        else if (chip->bus == SENSORS_CHIP_NAME_BUS_DUMMY)
        {
-               snprintf (buf, buf_size, "%s-%s-%04x",
+               status = snprintf (buf, buf_size, "%s-%s-%04x",
                                chip->prefix,
                                chip->busname,
                                chip->addr);
        }
        else
        {
-               snprintf (buf, buf_size, "%s-i2c-%d-%02x",
+               status = snprintf (buf, buf_size, "%s-i2c-%d-%02x",
                                chip->prefix,
                                chip->bus,
                                chip->addr);