summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 91ede7c)
raw | patch | inline | side by side (parent: 91ede7c)
author | Florian Forster <octo@collectd.org> | |
Wed, 12 Oct 2016 15:25:13 +0000 (17:25 +0200) | ||
committer | Florian Forster <octo@collectd.org> | |
Sun, 27 Nov 2016 06:55:29 +0000 (07:55 +0100) |
src/utils_latency.c | patch | blob | history | |
src/utils_latency_config.c | patch | blob | history | |
src/utils_latency_config.h | patch | blob | history |
diff --git a/src/utils_latency.c b/src/utils_latency.c
index f5a51e2529f040ffff3ebcd4c5106998fb065184..5749f10da199700c0b18e0c36020e6f2f9c072a1 100644 (file)
--- a/src/utils_latency.c
+++ b/src/utils_latency.c
return (latency_interpolated);
} /* }}} cdtime_t latency_counter_get_percentile */
-double latency_counter_get_rate (const latency_counter_t *lc, /* {{{ */
- cdtime_t lower, cdtime_t upper, const cdtime_t now)
-{
+double latency_counter_get_rate(const latency_counter_t *lc, /* {{{ */
+ cdtime_t lower, cdtime_t upper,
+ const cdtime_t now) {
if ((lc == NULL) || (lc->num == 0))
return (NAN);
cdtime_t lower_bin = 0;
if (lower)
/* lower is *exclusive* => determine bucket for lower+1 */
- lower_bin = ((lower+1) - 1) / lc->bin_width;
+ lower_bin = ((lower + 1) - 1) / lc->bin_width;
/* lower is greater than the longest latency observed => rate is zero. */
if (lower_bin >= HISTOGRAM_NUM_BINS)
* lower_bin_boundary and lower. This ratio is then subtracted from sum to
* increase accuracy. */
cdtime_t lower_bin_boundary = lower_bin * lc->bin_width;
- assert (lower >= lower_bin_boundary);
- double lower_ratio = (double)(lower - lower_bin_boundary) / ((double) lc->bin_width);
+ assert(lower >= lower_bin_boundary);
+ double lower_ratio =
+ (double)(lower - lower_bin_boundary) / ((double)lc->bin_width);
sum -= lower_ratio * lc->histogram[lower_bin];
}
- if (upper)
- {
+ if (upper) {
/* As above: approximate ratio of requests in upper_bin, that fall between
* upper and upper_bin_boundary. */
cdtime_t upper_bin_boundary = (upper_bin + 1) * lc->bin_width;
- assert (upper <= upper_bin_boundary);
+ assert(upper <= upper_bin_boundary);
double ratio = (double)(upper_bin_boundary - upper) / (double)lc->bin_width;
sum -= ratio * lc->histogram[upper_bin];
}
- return sum / (CDTIME_T_TO_DOUBLE (now - lc->start_time));
+ return sum / (CDTIME_T_TO_DOUBLE(now - lc->start_time));
} /* }}} double latency_counter_get_rate */
/* vim: set sw=2 sts=2 et fdm=marker : */
index 2121e54673cf8366588ac8343b0014e078444050..f99fe583beeff525a70eec61dc0b38c08e745c7e 100644 (file)
#include "utils_latency_config.h"
int latency_config_add_percentile(const char *plugin, latency_config_t *cl,
- oconfig_item_t *ci)
-{
- if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_NUMBER))
- {
+ oconfig_item_t *ci) {
+ if ((ci->values_num != 1) || (ci->values[0].type != OCONFIG_TYPE_NUMBER)) {
ERROR("%s plugin: \"%s\" requires exactly one numeric argument.", plugin,
ci->key);
return (-1);
double percent = ci->values[0].value.number;
double *tmp;
- if ((percent <= 0.0) || (percent >= 100))
- {
+ if ((percent <= 0.0) || (percent >= 100)) {
ERROR("%s plugin: The value for \"%s\" must be between 0 and 100, "
"exclusively.",
plugin, ci->key);
tmp = realloc(cl->percentile,
sizeof(*cl->percentile) * (cl->percentile_num + 1));
- if (tmp == NULL)
- {
+ if (tmp == NULL) {
ERROR("%s plugin: realloc failed.", plugin);
return (ENOMEM);
}
} /* int latency_config_add_percentile */
int latency_config_add_rate(const char *plugin, latency_config_t *cl,
- oconfig_item_t *ci)
-{
- if ((ci->values_num != 2)
- || (ci->values[0].type != OCONFIG_TYPE_NUMBER)
- || (ci->values[1].type != OCONFIG_TYPE_NUMBER))
- {
+ oconfig_item_t *ci) {
+ if ((ci->values_num != 2) || (ci->values[0].type != OCONFIG_TYPE_NUMBER) ||
+ (ci->values[1].type != OCONFIG_TYPE_NUMBER)) {
ERROR("%s plugin: \"%s\" requires exactly two numeric arguments.", plugin,
ci->key);
return (-1);
}
if (ci->values[1].value.number &&
- ci->values[1].value.number <= ci->values[0].value.number)
- {
+ ci->values[1].value.number <= ci->values[0].value.number) {
ERROR("%s plugin: MIN must be less than MAX in \"%s\".", plugin, ci->key);
return (-1);
}
- if (ci->values[0].value.number < 0.001)
- {
+ if (ci->values[0].value.number < 0.001) {
ERROR("%s plugin: MIN must be greater or equal to 0.001 in \"%s\".", plugin,
ci->key);
return (-1);
cdtime_t *tmp;
tmp = realloc(cl->rates, sizeof(*cl->rates) * (cl->rates_num + 1) * 2);
- if (tmp == NULL)
- {
+ if (tmp == NULL) {
ERROR("%s plugin: realloc failed.", plugin);
return (ENOMEM);
}
return (0);
} /* int latency_config_add_rate */
-int latency_config_copy(latency_config_t *dst, const latency_config_t src)
-{
+int latency_config_copy(latency_config_t *dst, const latency_config_t src) {
*dst = (latency_config_t){
- .rates = NULL,
- .rates_num = src.rates_num,
- .rates_type = NULL,
- .percentile = NULL,
- .percentile_num = src.percentile_num,
- .percentile_type = NULL,
+ .rates = NULL,
+ .rates_num = src.rates_num,
+ .rates_type = NULL,
+ .percentile = NULL,
+ .percentile_num = src.percentile_num,
+ .percentile_type = NULL,
};
/* Copy percentiles configuration */
memcpy(dst->percentile, src.percentile,
(sizeof(*dst->percentile) * (src.percentile_num)));
- if (src.percentile_type != NULL)
- {
+ if (src.percentile_type != NULL) {
dst->percentile_type = strdup(src.percentile_type);
- if (dst->percentile_type == NULL)
- {
+ if (dst->percentile_type == NULL) {
latency_config_free(*dst);
return (-1);
}
/* Copy rates configuration */
dst->rates_num = src.rates_num;
dst->rates = calloc(src.rates_num * 2, sizeof(*dst->rates));
- if (dst->rates == NULL)
- {
+ if (dst->rates == NULL) {
latency_config_free(*dst);
return (-1);
}
memcpy(dst->rates, src.rates, (sizeof(*dst->rates) * (src.rates_num) * 2));
- if (src.rates_type != NULL)
- {
+ if (src.rates_type != NULL) {
dst->rates_type = strdup(src.rates_type);
- if (dst->rates_type == NULL)
- {
+ if (dst->rates_type == NULL) {
latency_config_free(*dst);
return (-1);
}
index aad8914cb7bfff94b944139670484525a42cf479..a5354960cd626dc972382858bd685ea516cbeb87 100644 (file)
#include "collectd.h"
#include "utils_time.h"
-struct latency_config_s
-{
- double *percentile;
- size_t percentile_num;
- char *percentile_type;
+struct latency_config_s {
+ double *percentile;
+ size_t percentile_num;
+ char *percentile_type;
cdtime_t *rates;
- size_t rates_num;
- char *rates_type;
- _Bool lower;
- _Bool upper;
+ size_t rates_num;
+ char *rates_type;
+ _Bool lower;
+ _Bool upper;
//_Bool sum;
- _Bool avg;
+ _Bool avg;
//_Bool count;
};
typedef struct latency_config_s latency_config_t;