Code

bisect: report bad rev better
authorChristian Couder <chriscool@tuxfamily.org>
Sat, 12 Apr 2008 09:17:36 +0000 (02:17 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sat, 12 Apr 2008 22:16:13 +0000 (15:16 -0700)
The previous one overwrote the variable used to report the bad input
when the input is actually bad, and we did not give a useful enough
information.  This corrects it.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-bisect.sh

index c8be9f7e8a33db81d9dbbfcd943eaa341aee7595..c99ffee122f9d4bd714fb3e6278cafd3e219891b 100755 (executable)
@@ -155,9 +155,9 @@ bisect_state() {
                shift
                for rev in "$@"
                do
-                       rev=$(git rev-parse --verify "$rev^{commit}") ||
+                       sha=$(git rev-parse --verify "$rev^{commit}") ||
                                die "Bad rev input: $rev"
-                       bisect_write "$state" "$rev"
+                       bisect_write "$state" "$sha"
                done ;;
        *,bad)
                die "'git bisect bad' can take only one argument." ;;