write_prometheus plugin: Fix incorrect use of realloc().

Calling realloc(ptr, 0) is undefined. Call free() explicitly.

diff --git a/src/write_prometheus.c b/src/write_prometheus.c
index 6b77712e8ed0ab37b5a09dcb0728bb75f96d0ce6..de1c389c30cc1a2f9ac4318e70d4f0ce5ac79d07 100644 (file)
--- a/src/write_prometheus.c
+++ b/src/write_prometheus.c
@@ -546,9 +546,14 @@ metric_family_delete_metric(Io__Prometheus__Client__MetricFamily *fam,
             ((fam->n_metric - 1) - i) * sizeof(fam->metric[i]));
   fam->n_metric--;
 
+  if (fam->n_metric == 0) {
+    sfree(fam->metric);
+    return 0;
+  }
+
   Io__Prometheus__Client__Metric **tmp =
       realloc(fam->metric, fam->n_metric * sizeof(*fam->metric));
-  if ((tmp != NULL) || (fam->n_metric == 0))
+  if (tmp != NULL)
     fam->metric = tmp;
 
   return 0;