Code

cvsserver: Abort if connect to database fails
authorFrank Lichtenheld <frank@lichtenheld.de>
Mon, 19 Mar 2007 15:56:01 +0000 (16:56 +0100)
committerJunio C Hamano <junkio@cox.net>
Thu, 22 Mar 2007 08:26:26 +0000 (01:26 -0700)
Currently all calls to the database backend make no
error checking or handling at all. At least abort
if the connection to the database failed since
there is really no way we could do anything useful
after that.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
git-cvsserver.perl

index 6d10aa33436b29a5e9a7a795818988daafc24eda..941a91bcac6bb54cbbe092f54c16753f49948e5a 100755 (executable)
@@ -2168,6 +2168,7 @@ sub new
     $self->{dbh} = DBI->connect("$self->{dbdriver}:dbname=$self->{dbname}",
                                 $self->{dbuser},
                                 $self->{dbpass});
+    die "Error connecting to database\n" unless defined $self->{dbh};
 
     $self->{tables} = {};
     foreach my $table ( $self->{dbh}->tables )