rrdtool plugin: Get the cache lock before checking for a nonexistent cache.

This should not make any difference, but, in theory, this is a semantical
error, so, let's just fix it :-)

Thanks to Stefan Völkel for pointing this out.

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>

diff --git a/src/rrdtool.c b/src/rrdtool.c
index 4e34d6ad0aac1bbb93a5c537d58f07e7a559a49c..ab245241146593fb278e5a3ac5a343020cedef25 100644 (file)
--- a/src/rrdtool.c
+++ b/src/rrdtool.c
@@ -949,10 +949,13 @@ static int rrd_write (const data_set_t *ds, const value_list_t *vl)
 
 static int rrd_flush (const int timeout)
 {
-       if (cache == NULL)
+       pthread_mutex_lock (&cache_lock);
+
+       if (cache == NULL) {
+               pthread_mutex_unlock (&cache_lock);
                return (0);
+       }
 
-       pthread_mutex_lock (&cache_lock);
        rrd_cache_flush (timeout);
        pthread_mutex_unlock (&cache_lock);
        return (0);