Code

Makefile: help people who run 'make check' by mistake
authorJunio C Hamano <gitster@pobox.com>
Tue, 11 Nov 2008 21:12:17 +0000 (13:12 -0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 11 Nov 2008 21:12:17 +0000 (13:12 -0800)
The target to run self test is 'make test', but there are people who try
'make check' and worse yet do not have sparse installed.

Suggest 'make test' target when they do not have 'sparse'.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Makefile

index becd008e04c265f7a822eeb74cfe218491710c7e..186a8efd1b74a0510e67e75a6191206a1a6818c2 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1329,7 +1329,16 @@ check-sha1:: test-sha1$X
        ./test-sha1.sh
 
 check: common-cmds.h
-       for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
+       if sparse; \
+       then \
+               for i in *.c; \
+               do \
+                       sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; \
+               done; \
+       else \
+               echo 2>&1 "Did you mean 'make test'?"; \
+               exit 1; \
+       fi
 
 remove-dashes:
        ./fixup-builtins $(BUILT_INS) $(PROGRAMS) $(SCRIPTS)