summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: be767c9)
raw | patch | inline | side by side (parent: be767c9)
author | Marco Roeland <marco.roeland@xs4all.nl> | |
Sat, 11 Mar 2006 08:55:50 +0000 (09:55 +0100) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Sat, 11 Mar 2006 10:00:35 +0000 (02:00 -0800) |
Some versions of gcc check that calls to the exec() family have the proper
sentinel for variadic calls. This should be (char *) NULL according to the
man page. Although for all other purposes the 0 is equivalent, gcc
nevertheless does emit a warning for 0 and not for NULL. This also makes the
usage consistent throughout git.
The whitespace in function calls throughout imap-send.c has its own style,
so I left it that way.
Signed-off-by: Junio C Hamano <junkio@cox.net>
sentinel for variadic calls. This should be (char *) NULL according to the
man page. Although for all other purposes the 0 is equivalent, gcc
nevertheless does emit a warning for 0 and not for NULL. This also makes the
usage consistent throughout git.
The whitespace in function calls throughout imap-send.c has its own style,
so I left it that way.
Signed-off-by: Junio C Hamano <junkio@cox.net>
imap-send.c | patch | blob | history |
diff --git a/imap-send.c b/imap-send.c
index fddaac00c0adea7347934b008da9b33e72fe5b5f..203284d8f01ad513a99d1fa432828ced6a8e7bd9 100644 (file)
--- a/imap-send.c
+++ b/imap-send.c
_exit( 127 );
close( a[0] );
close( a[1] );
- execl( "/bin/sh", "sh", "-c", srvc->tunnel, 0 );
+ execl( "/bin/sh", "sh", "-c", srvc->tunnel, NULL );
_exit( 127 );
}