summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: a9877f8)
raw | patch | inline | side by side (parent: a9877f8)
author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | |
Tue, 16 Jan 2007 21:10:54 +0000 (22:10 +0100) | ||
committer | Junio C Hamano <junkio@cox.net> | |
Tue, 16 Jan 2007 21:43:50 +0000 (13:43 -0800) |
From time to time, I would get this error:
[...]
sed: -e expression #8, char 41: Unterminated `s' command
make: *** [git-add--interactive] Error 1
Turns out that the function WriteMakefile() called in Makefile.PL
outputs the message "Writing perl.mak for Git" to stdout! Thus,
the output of "make -C perl -s --no-print-directory instlibdir"
would be prefixed by that message whenever Makefile.PL was newer
than perl.mak.
This is fixed by redirecting stdout to stderr in Makefile.PL.
Signed-off-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
[...]
sed: -e expression #8, char 41: Unterminated `s' command
make: *** [git-add--interactive] Error 1
Turns out that the function WriteMakefile() called in Makefile.PL
outputs the message "Writing perl.mak for Git" to stdout! Thus,
the output of "make -C perl -s --no-print-directory instlibdir"
would be prefixed by that message whenever Makefile.PL was newer
than perl.mak.
This is fixed by redirecting stdout to stderr in Makefile.PL.
Signed-off-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
perl/Makefile.PL | patch | blob | history |
diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 41687757a7fdd9c09bd320b92ed7f089af00a403..9b117fd0d736615a8c4aeda742384956373d295a 100644 (file)
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
my %extra;
$extra{DESTDIR} = $ENV{DESTDIR} if $ENV{DESTDIR};
+# redirect stdout, otherwise the message "Writing perl.mak for Git"
+# disrupts the output for the target 'instlibdir'
+open STDOUT, ">&STDERR";
+
WriteMakefile(
NAME => 'Git',
VERSION_FROM => 'Git.pm',