Code

ident.c: replace fprintf with fputs to suppress compiler warning
authorTarmigan Casebolt <tarmigan+git@gmail.com>
Sun, 17 Jan 2010 08:19:24 +0000 (00:19 -0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 19 Jan 2010 23:25:38 +0000 (15:25 -0800)
Compiling today's pu gave
    ...
    CC ident.o
    CC levenshtein.o
ident.c: In function 'fmt_ident':
ident.c:206: warning: format not a string literal and no format arguments
    CC list-objects.o
    ...

This warning seems to have appeared first in 18e95f279ec6 (ident.c:
remove unused variables) which removed additional fprintf arguments.

Suppress this warning by using fputs instead of fprintf.

Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
ident.c

diff --git a/ident.c b/ident.c
index 96b56e66d14b2f5f69792eb8d1597667f5fdbb0c..9e2438826dfce158e04549933d5c588dd6abcf5c 100644 (file)
--- a/ident.c
+++ b/ident.c
@@ -203,7 +203,7 @@ const char *fmt_ident(const char *name, const char *email,
 
                if ((warn_on_no_name || error_on_no_name) &&
                    name == git_default_name && env_hint) {
-                       fprintf(stderr, env_hint);
+                       fputs(env_hint, stderr);
                        env_hint = NULL; /* warn only once */
                }
                if (error_on_no_name)