Code

decode_85(): fix missing return.
authorJerald Fitzjerald <jfj@freemail.gr>
Wed, 30 May 2007 12:39:58 +0000 (05:39 -0700)
committerJunio C Hamano <junkio@cox.net>
Wed, 30 May 2007 22:03:50 +0000 (15:03 -0700)
When the function detected an invalid base85 sequence, it issued
an error message but forgot to return error status at that point
and kept going.

Signed-off-by: Jerald Fitzjerald <jfj@freemail.gr>
Signed-off-by: Junio C Hamano <junkio@cox.net>
base85.c

index a6c41d597ab8eccb5eb2ccf2b3b543398c360b44..b88270f90844095b3d352cc4213cbebd95a7f420 100644 (file)
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buffer, int len)
                 */
                if (0x03030303 < acc ||
                    0xffffffff - de < (acc *= 85))
-                       error("invalid base85 sequence %.5s", buffer-5);
+                       return error("invalid base85 sequence %.5s", buffer-5);
                acc += de;
                say1(" %08x", acc);