summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0af88c1)
raw | patch | inline | side by side (parent: 0af88c1)
author | Brandon Casey <drafnel@gmail.com> | |
Mon, 21 Jun 2010 17:37:13 +0000 (12:37 -0500) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 21 Jun 2010 18:11:11 +0000 (11:11 -0700) |
Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string. Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'. Additionally, GNU expr 5.97 complains like this:
expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
of them and so are anchored to the beginning of the string. Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'. Additionally, GNU expr 5.97 complains like this:
expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-pager.sh | patch | blob | history |
diff --git a/t/lib-pager.sh b/t/lib-pager.sh
index f8c602587693d2739dfd6e06b9d5d8126de62cf6..ba03eab14fc29934f095673fa82af658b06bf865 100644 (file)
--- a/t/lib-pager.sh
+++ b/t/lib-pager.sh
test -n "$less"
'
-if expr "$less" : '^[a-z][a-z]*$' >/dev/null
+if expr "$less" : '[a-z][a-z]*$' >/dev/null
then
test_set_prereq SIMPLEPAGER
fi