Code

git-gui: Quote git path when starting another gui in a submodule
authorJens Lehmann <Jens.Lehmann@web.de>
Thu, 28 Jan 2010 21:20:39 +0000 (22:20 +0100)
committerShawn O. Pearce <spearce@spearce.org>
Thu, 28 Jan 2010 23:44:41 +0000 (15:44 -0800)
In do_git_gui the path of the git executable has to be put into a
list, otherwise calling it will fail when when spaces are present
in its path.

Reported-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
git-gui.sh

index 574954758517acfb347c1fb64f5e161a470f5261..debcc5f41bafe47f90ad95cc2fcf6b7cd4e4bcc4 100755 (executable)
@@ -2059,7 +2059,7 @@ proc do_git_gui {} {
        # -- Always start git gui through whatever we were loaded with.  This
        #    lets us bypass using shell process on Windows systems.
        #
-       set exe [_which git]
+       set exe [list [_which git]]
        if {$exe eq {}} {
                error_popup [mc "Couldn't find git gui in PATH"]
        } else {