Code

Only run aggregate-results over actual counts
authorThomas Rast <trast@student.ethz.ch>
Fri, 16 Jul 2010 09:37:44 +0000 (11:37 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 16 Jul 2010 20:25:01 +0000 (13:25 -0700)
The current make target 'aggregate-results' scanned all files matching
test-results/t*-*.  Normally these are only the test counts (and the
exit values, which are ignored), but with --tee the suite also dumps
all output.  Furthermore, with --verbose t1450 contains several lines
starting with "broken link from ..." which matches the criteria used
by aggregate-results.sh.

Rename the counts output files to *.counts, and only scan those.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Acked-by: Sverre Rabbelier <srabbelier@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/Makefile
t/test-lib.sh

index f9de24b4d2baa9fad1d6caa72fea651da78d6878..cf5f9e2e1eb17c442220464d06374e6c529f8629 100644 (file)
@@ -36,7 +36,7 @@ aggregate-results-and-cleanup: $(T)
        $(MAKE) clean
 
 aggregate-results:
-       for f in test-results/t*-*; do \
+       for f in test-results/t*-*.counts; do \
                echo "$$f"; \
        done | '$(SHELL_PATH_SQ)' ./aggregate-results.sh
 
index db8371cb170c5924512a5626681f485ea3cf6884..e5523dd690a43fdcf315e7e952d4d316182eeb25 100644 (file)
@@ -636,7 +636,7 @@ test_done () {
        GIT_EXIT_OK=t
        test_results_dir="$TEST_DIRECTORY/test-results"
        mkdir -p "$test_results_dir"
-       test_results_path="$test_results_dir/${0%.sh}-$$"
+       test_results_path="$test_results_dir/${0%.sh}-$$.counts"
 
        echo "total $test_count" >> $test_results_path
        echo "success $test_success" >> $test_results_path