snmp_agent plugin: Fix memory leak.

Allocate "entry" later so that the error handling blocks don't leak it.

CID: 179244

diff --git a/src/snmp_agent.c b/src/snmp_agent.c
index 497d157c07a0193479daeda36002d7bdf2aee4ec..948107b5b62eee002c462886d5238368cd8c7adc 100644 (file)
--- a/src/snmp_agent.c
+++ b/src/snmp_agent.c
@@ -1117,12 +1117,6 @@ static int snmp_agent_config_table(oconfig_item_t *ci) {
     }
   }
 
-  llentry_t *entry = llentry_create(td->name, td);
-  if (entry == NULL) {
-    snmp_agent_free_table(&td);
-    return -ENOMEM;
-  }
-
   td->instance_index =
       c_avl_create((int (*)(const void *, const void *))strcmp);
   if (td->instance_index == NULL) {
@@ -1137,6 +1131,11 @@ static int snmp_agent_config_table(oconfig_item_t *ci) {
     return -ENOMEM;
   }
 
+  llentry_t *entry = llentry_create(td->name, td);
+  if (entry == NULL) {
+    snmp_agent_free_table(&td);
+    return -ENOMEM;
+  }
   llist_append(g_agent->tables, entry);
 
   return 0;