email plugin: Free "connection" in error handling.

CID: 38010

diff --git a/src/email.c b/src/email.c
index fdcf0677837e25cb27e50e78ad6c69f17be7bc3c..7493cc6d6967bc07255d7fb91a12bb5a6039974b 100644 (file)
--- a/src/email.c
+++ b/src/email.c
@@ -520,13 +520,20 @@ static void *open_connection (void __attribute__((unused)) *arg)
                        }
                } while (EINTR == errno);
 
-               connection = (conn_t *)smalloc (sizeof (conn_t));
+               connection = malloc (sizeof (*connection));
+               if (connection != NULL)
+               {
+                       close (remote);
+                       continue;
+               }
+               memset (connection, 0, sizeof (*connection));
 
                connection->socket = fdopen (remote, "r");
                connection->next   = NULL;
 
                if (NULL == connection->socket) {
                        close (remote);
+                       sfree (connection);
                        continue;
                }