Code

git-p4: Fix regression in p4Where method.
authorTor Arvid Lund <torarvid@gmail.com>
Tue, 9 Dec 2008 15:41:50 +0000 (16:41 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 10 Dec 2008 05:39:16 +0000 (21:39 -0800)
Unfortunately, I introduced a bug in commit 7f705dc36 (git-p4: Fix bug in
p4Where method). This happens because sometimes the result from
"p4 where <somepath>" doesn't contain a "depotFile" key, but instead a
"data" key that needs further parsing. This commit should ensure that both
of these cases are checked.

Signed-off-by: Tor Arvid Lund <torarvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/fast-import/git-p4

index ee504e90ed81720829f547d0a1bff41f368be18c..a85a7b2a583ee9270fc2d765ec8c8c6e9d6b5e32 100755 (executable)
@@ -249,9 +249,16 @@ def p4Where(depotPath):
     outputList = p4CmdList("where %s" % depotPath)
     output = None
     for entry in outputList:
-        if entry["depotFile"] == depotPath:
-            output = entry
-            break
+        if "depotFile" in entry:
+            if entry["depotFile"] == depotPath:
+                output = entry
+                break
+        elif "data" in entry:
+            data = entry.get("data")
+            space = data.find(" ")
+            if data[:space] == depotPath:
+                output = entry
+                break
     if output == None:
         return ""
     if output["code"] == "error":