Generic class editor may now restore retired items (thanks Ralf Hemmecke)

git-svn-id: http://svn.roundup-tracker.org/svnroot/roundup/roundup/trunk@4397 57a73879-2fb5-44c3-a270-3262357dd7e2

diff --git a/CHANGES.txt b/CHANGES.txt
index d219cdd51e3c1986602b0365ff6353459ed8767a..cfe434a513186c87bb00fb2a9fb7622c2fe41bd2 100644 (file)
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -3,6 +3,9 @@ are given with the most recent entry first.
 
 2009-XX-XX 1.4.XX (rXXXX)
 
+Features:
+- Generic class editor may now restore retired items (thanks Ralf Hemmecke)
+
 Fixes:
 - More SSL fixes. SSL wants the underlying socket non-blocking. So we
   don't call socket.setdefaulttimeout in case of SSL. This apparently

diff --git a/doc/acknowledgements.txt b/doc/acknowledgements.txt
index 5eb7ff438a3f0e1d23e1d3a6012da8e8499b6e25..f287c446d9ec9c57ec8a78c1027c7d3f89319509 100644 (file)
--- a/doc/acknowledgements.txt
+++ b/doc/acknowledgements.txt
@@ -51,6 +51,7 @@ Charles Groves,
 Engelbert Gruber,
 Bruce Guenter,
 Tamás Gulácsi,
+Ralf Hemmecke,
 Juergen Hermann,
 Tobias Herp,
 Uwe Hoffmann,

diff --git a/roundup/cgi/actions.py b/roundup/cgi/actions.py
index eaf4c28a5b57080a455702ecefc997e1d94b3fad..54af46911ad4fcb3d0953b6cf17542ed4462486b 100755 (executable)
--- a/roundup/cgi/actions.py
+++ b/roundup/cgi/actions.py
@@ -320,6 +320,11 @@ class EditCSVAction(Action):
                     raise exceptions.Unauthorised, self._(
                         'You do not have permission to create %(class)s'
                     ) % {'class': self.classname}
+            elif cl.hasnode(itemid) and cl.is_retired(itemid):
+                # If a CSV line just mentions an id and the corresponding
+                # item is retired, then the item is restored.
+                cl.restore(itemid)
+                continue
             else:
                 exists = 1
 

diff --git a/share/roundup/templates/classic/html/_generic.index.html b/share/roundup/templates/classic/html/_generic.index.html
index a41ab0ac190624a4025b66aacf803370b3b380cd..3dd34a070d42f9ba4dc3f2ffd8d0935d07a93997 100644 (file)
--- a/share/roundup/templates/classic/html/_generic.index.html
+++ b/share/roundup/templates/classic/html/_generic.index.html
@@ -39,7 +39,8 @@
 
 <p class="form-help">
  Remove entries by deleting their line. Add new entries by appending
- them to the table - put an X in the id column.
+ them to the table - put an X in the id column. If you wish to restore a
+ removed item and you know its id then just put that id in the id column.
 </p>
 </tal:block>
 <form onSubmit="return submit_once()" method="POST"

diff --git a/share/roundup/templates/minimal/html/_generic.index.html b/share/roundup/templates/minimal/html/_generic.index.html
index 81918ef8401c870c58c65724171d022fb3165f96..fd55b2da1d038527d7fad24d87caeaf4d7618835 100644 (file)
--- a/share/roundup/templates/minimal/html/_generic.index.html
+++ b/share/roundup/templates/minimal/html/_generic.index.html
@@ -39,7 +39,8 @@
 
 <p class="form-help">
  Remove entries by deleting their line. Add new entries by appending
- them to the table - put an X in the id column.
+ them to the table - put an X in the id column. If you wish to restore a
+ removed item and you know its id then just put that id in the id column.
 </p>
 </tal:block>
 <form onSubmit="return submit_once()" method="POST"