Code

gitk: Fix bug in accessing undefined "notflag" variable
authorPaul Mackerras <paulus@samba.org>
Mon, 1 Dec 2008 22:17:46 +0000 (09:17 +1100)
committerPaul Mackerras <paulus@samba.org>
Mon, 1 Dec 2008 22:28:06 +0000 (09:28 +1100)
As pointed out by Johannes Sixt and Alexander Gavrilov, commit
2958228430b63f2e38c55519d1f98d8d6d9e23f3 ("gitk: Fix switch statement
in parseviewargs") exposed a latent bug in that $notflag was never
initialized.  Since it isn't used either, this removes it entirely.

Signed-off-by: Paul Mackerras <paulus@samba.org>
gitk

diff --git a/gitk b/gitk
index 52d8aaef895909c4e62a4b4d540f2ac60a092370..b7447f91c0a51a8d6a48ff72e7c2c49d0bff46d1 100755 (executable)
--- a/gitk
+++ b/gitk
@@ -199,11 +199,7 @@ proc parseviewargs {n arglist} {
                set nextisval 1
                lappend glflags $arg
            }
-           "--not" {
-               set notflag [expr {!$notflag}]
-               lappend revargs $arg
-           }
-           "--all" {
+           "--not" - "--all" {
                lappend revargs $arg
            }
            "--merge" {