summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 19c8214)
raw | patch | inline | side by side (parent: 19c8214)
author | Shawn O. Pearce <spearce@spearce.org> | |
Tue, 17 Apr 2007 17:15:56 +0000 (13:15 -0400) | ||
committer | Shawn O. Pearce <spearce@spearce.org> | |
Tue, 17 Apr 2007 17:15:56 +0000 (13:15 -0400) |
This reverts commit e2a1bc67d321a0c03737179f331c39a52e7049d7.
Junio rightly pointed out this patch doesn't handle the
`make install` target very well:
Junio C Hamano <junkio@cox.net> writes:
> You should never generate new files in the source tree from
> 'install' target. Otherwise, the usual pattern of "make" as
> yourself and then "make install" as root would not work from a
> "root-to-nobody-squashing" NFS mounted source tree to local
> filesystem. You should know better than accepting such a patch.
Junio rightly pointed out this patch doesn't handle the
`make install` target very well:
Junio C Hamano <junkio@cox.net> writes:
> You should never generate new files in the source tree from
> 'install' target. Otherwise, the usual pattern of "make" as
> yourself and then "make install" as root would not work from a
> "root-to-nobody-squashing" NFS mounted source tree to local
> filesystem. You should know better than accepting such a patch.
Makefile | patch | blob | history |
diff --git a/Makefile b/Makefile
index 2316b24e002f73b2f70a93a13c081216e4ef21fe..b82789ead6255b33be0f1ed2029a91611cea3072 100644 (file)
--- a/Makefile
+++ b/Makefile
QUIET_BUILT_IN = @echo ' ' BUILTIN $@;
endif
-TCLTK_PATH ?= wish
-
ifeq ($(findstring $(MAKEFLAGS),s),s)
QUIET_GEN =
QUIET_BUILT_IN =
install: all
$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(gitexecdir_SQ)'
- sed -i .bak -e'1,3s|^exec .* "$$0"|exec '"$(TCLTK_PATH)"' "$$0"|' git-gui && rm git-gui.bak
$(INSTALL) git-gui '$(DESTDIR_SQ)$(gitexecdir_SQ)'
$(foreach p,$(GITGUI_BUILT_INS), rm -f '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' && ln '$(DESTDIR_SQ)$(gitexecdir_SQ)/git-gui' '$(DESTDIR_SQ)$(gitexecdir_SQ)/$p' ;)