summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 98e38ad)
raw | patch | inline | side by side (parent: 98e38ad)
author | Francesco Romani <fromani@redhat.com> | |
Thu, 24 Nov 2016 09:16:00 +0000 (10:16 +0100) | ||
committer | Francesco Romani <fromani@redhat.com> | |
Wed, 30 Nov 2016 09:27:00 +0000 (10:27 +0100) |
Old libvirts (<= 0.10.z, such as the version shipped on debian wheezy)
depend on libnl-1. There is a small memory leak caused by the
initialization of the library, and we have no means to avoid it.
This causes valgrind to complain in the tests, creating a false
positive.
Anyway, libvirt switched to libnl-3, which should also fix this leak.
The simplest solution is just to disable those tests until we
can depend on libnl-3 enabled libvirt.
depend on libnl-1. There is a small memory leak caused by the
initialization of the library, and we have no means to avoid it.
This causes valgrind to complain in the tests, creating a false
positive.
Anyway, libvirt switched to libnl-3, which should also fix this leak.
The simplest solution is just to disable those tests until we
can depend on libnl-3 enabled libvirt.
src/Makefile.am | patch | blob | history |
diff --git a/src/Makefile.am b/src/Makefile.am
index 0601ce9f7e7ab97262b34e11dcb88c136179e842..a389b3c429c7bd712d349fa515a6bcd0de28f8b5 100644 (file)
--- a/src/Makefile.am
+++ b/src/Makefile.am
test_plugin_virt_LDFLAGS = $(PLUGIN_LDFLAGS)
test_plugin_virt_LDADD = daemon/libplugin_mock.la \
$(BUILD_WITH_LIBVIRT_LIBS) $(BUILD_WITH_LIBXML2_LIBS)
-check_PROGRAMS += test_plugin_virt
-TESTS += test_plugin_virt
-
+# TODO: enable once we support only modern libvirts which depends on libnl-3
+# the libvirt on wheezy is linked in libnl v1, and there is a small leak here,
+# triggered by the library initialization. There are no means to avoid it,
+# and libvirt switched to libnl3 anyway
+#check_PROGRAMS += test_plugin_virt
+#TESTS += test_plugin_virt
endif
if BUILD_PLUGIN_VMEM